-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for parallel mp3 to wav conversion, PC notebook, update Readme for TN requirements #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekmb <ebakhturina@nvidia.com>
Signed-off-by: ekmb <ebakhturina@nvidia.com>
Signed-off-by: ekmb <ebakhturina@nvidia.com>
Signed-off-by: ekmb <ebakhturina@nvidia.com>
Signed-off-by: ekmb <ebakhturina@nvidia.com>
vsl9
approved these changes
Sep 30, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
…dme for TN requirements (#5047) * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * install pynini Signed-off-by: ekmb <ebakhturina@nvidia.com> * add requirements install back Signed-off-by: ekmb <ebakhturina@nvidia.com> * update sox requirements Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com>
ekmb
added a commit
that referenced
this pull request
Sep 30, 2022
…dme for TN requirements (#5047) (#5053) * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * install pynini Signed-off-by: ekmb <ebakhturina@nvidia.com> * add requirements install back Signed-off-by: ekmb <ebakhturina@nvidia.com> * update sox requirements Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 3, 2022
…dme for TN requirements (NVIDIA#5047) * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * install pynini Signed-off-by: ekmb <ebakhturina@nvidia.com> * add requirements install back Signed-off-by: ekmb <ebakhturina@nvidia.com> * update sox requirements Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 3, 2022
…dme for TN requirements (NVIDIA#5047) * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * install pynini Signed-off-by: ekmb <ebakhturina@nvidia.com> * add requirements install back Signed-off-by: ekmb <ebakhturina@nvidia.com> * update sox requirements Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Oct 6, 2022
…dme for TN requirements (NVIDIA#5047) (NVIDIA#5053) * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * install pynini Signed-off-by: ekmb <ebakhturina@nvidia.com> * add requirements install back Signed-off-by: ekmb <ebakhturina@nvidia.com> * update sox requirements Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
…dme for TN requirements (NVIDIA#5047) (NVIDIA#5053) * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * install pynini Signed-off-by: ekmb <ebakhturina@nvidia.com> * add requirements install back Signed-off-by: ekmb <ebakhturina@nvidia.com> * update sox requirements Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
…dme for TN requirements (NVIDIA#5047) (NVIDIA#5053) * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * bug fixes segmenation, pc Signed-off-by: ekmb <ebakhturina@nvidia.com> * install pynini Signed-off-by: ekmb <ebakhturina@nvidia.com> * add requirements install back Signed-off-by: ekmb <ebakhturina@nvidia.com> * update sox requirements Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Signed-off-by: ekmb <ebakhturina@nvidia.com> Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information