Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs #5036

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Fix bugs #5036

merged 2 commits into from
Sep 29, 2022

Conversation

Zhilin123
Copy link
Collaborator

What does this PR do ?

Fix bugs relating to dialogue and question answering due to pytorch lightning and transformers version upgrade

Collection: nlp

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

ericharper
ericharper approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Zhilin123 Zhilin123 merged commit a036287 into r1.12.0 Sep 29, 2022
github-actions bot pushed a commit that referenced this pull request Sep 29, 2022
@Zhilin123 @web-flow
Fix bugs (#5036)
d0d4023
@ericharper ericharper deleted the fix_bugs_qa_and_dialogue branch September 29, 2022 05:09
SeanNaren pushed a commit that referenced this pull request Sep 29, 2022
@github-actions @Zhilin123
Fix bugs (#5036) (#5039)
d3a12aa 
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 3, 2022
@github-actions @Zhilin123 @jubick1337
Fix bugs (NVIDIA#5036) (NVIDIA#5039)
ffdc52a 
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Oct 6, 2022
@github-actions @Zhilin123 @titu1994
Fix bugs (NVIDIA#5036) (NVIDIA#5039)
36d80ee 
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@github-actions @Zhilin123
Fix bugs (NVIDIA#5036) (NVIDIA#5039)
25f4400 
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@github-actions @Zhilin123
Fix bugs (NVIDIA#5036) (NVIDIA#5039)
57b2df3 
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhilin123 @ericharper