-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zh tn #5035
Merged
Merged
Fix zh tn #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
ericharper
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
ericharper
pushed a commit
that referenced
this pull request
Sep 29, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 3, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 4, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 4, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 4, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Oct 6, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* add missing files for package Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add core as dependecy to nemo_text_processing Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
fixing chinese tn and adding nemo core to text_processing package