Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zh tn #5035

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Fix zh tn #5035

merged 2 commits into from
Sep 29, 2022

Conversation

yzhang123
Copy link
Contributor

What does this PR do ?

fixing chinese tn and adding nemo core to text_processing package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 1ce05da into r1.12.0 Sep 29, 2022
@ericharper ericharper deleted the fix_zh_tn branch September 29, 2022 05:08
github-actions bot pushed a commit that referenced this pull request Sep 29, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
ericharper pushed a commit that referenced this pull request Sep 29, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 3, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 4, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 4, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 4, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Oct 6, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* add missing files for package

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add core as dependecy to nemo_text_processing

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants