Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diarization ASR inference link in notebook #5016

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

SeanNaren
Copy link
Collaborator

@SeanNaren SeanNaren commented Sep 27, 2022

What does this PR do ?

Fixes invalid link in notebook.

Collection: ASR

Changelog

  • Fix invalid ASR inference link.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
@titu1994 titu1994 merged commit 421f3b1 into r1.12.0 Sep 27, 2022
@titu1994 titu1994 deleted the fix/diar_link branch September 27, 2022 15:50
github-actions bot pushed a commit that referenced this pull request Sep 27, 2022
* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
SeanNaren added a commit that referenced this pull request Sep 27, 2022
* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
titu1994 pushed a commit that referenced this pull request Sep 27, 2022
* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Jorjeous pushed a commit that referenced this pull request Sep 27, 2022
* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: George Zelenfroynd <zelenfr@ya.ru>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Sep 28, 2022
…5021)

* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 3, 2022
…5021)

* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Oct 6, 2022
…5021)

* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
…5021)

* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
…5021)

* Fix diarization ASR inference link in notebook

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

* Update tutorials/speaker_tasks/ASR_with_SpeakerDiarization.ipynb

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>

Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants