Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] bugfix 'EnglishPhonemesTokenizer' object has no attribute 'encode_from_g2p' #4992

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

XuesongYang
Copy link
Collaborator

Signed-off-by: Xuesong Yang 1646669+XuesongYang@users.noreply.github.com

What does this PR do ?

fix the bug of tokenizer below,

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In [16], line 13
     10 print(pron2_g2p)
     12 # Tokenize!
---> 13 pron1_tokens = aligner.tokenizer.encode_from_g2p(pron1_g2p)
     14 pron2_tokens = aligner.tokenizer.encode_from_g2p(pron2_g2p)
     15 print("\n=== Tokens===")

AttributeError: 'EnglishPhonemesTokenizer' object has no attribute 'encode_from_g2p'

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@XuesongYang XuesongYang requested review from ekmb and redoctopus and removed request for ekmb September 23, 2022 09:08
…om_g2p process to fix aligner bug.

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
@ekmb ekmb merged commit dccc95e into r1.12.0 Sep 23, 2022
@ekmb ekmb deleted the fix-aligner-encode branch September 23, 2022 18:57
github-actions bot pushed a commit that referenced this pull request Sep 23, 2022
…om_g2p process to fix aligner bug. (#4992)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
XuesongYang added a commit that referenced this pull request Sep 23, 2022
…om_g2p process to fix aligner bug. (#4992)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
XuesongYang pushed a commit that referenced this pull request Sep 24, 2022
…om_g2p process to fix aligner bug. (#4992) (#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
SeanNaren pushed a commit that referenced this pull request Sep 26, 2022
…om_g2p process to fix aligner bug. (#4992) (#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Jorjeous pushed a commit that referenced this pull request Sep 27, 2022
…om_g2p process to fix aligner bug. (#4992) (#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: George Zelenfroynd <zelenfr@ya.ru>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Sep 28, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 3, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Oct 6, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000)

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants