-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTS] bugfix 'EnglishPhonemesTokenizer' object has no attribute 'encode_from_g2p' #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuesongYang
requested review from
ekmb and
redoctopus
and removed request for
ekmb
September 23, 2022 09:08
…om_g2p process to fix aligner bug. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
XuesongYang
force-pushed
the
fix-aligner-encode
branch
from
September 23, 2022 16:58
a126ba0
to
1cb3409
Compare
ekmb
approved these changes
Sep 23, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
…om_g2p process to fix aligner bug. (#4992) Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
XuesongYang
added a commit
that referenced
this pull request
Sep 23, 2022
…om_g2p process to fix aligner bug. (#4992) Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Sep 28, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000) Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 3, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000) Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Oct 6, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000) Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000) Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
…om_g2p process to fix aligner bug. (NVIDIA#4992) (NVIDIA#5000) Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuesong Yang 1646669+XuesongYang@users.noreply.github.com
What does this PR do ?
fix the bug of tokenizer below,
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information