Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dividing generative question-answering CI tests #4600

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Conversation

ameyasm1154
Copy link
Contributor

Signed-off-by: Ameya Mahabaleshwarkar ameyasm1154@gmail.com

What does this PR do ?

Split CI tests for generative question-answering into multiple stages to reduce memory usage

Collection: nlp

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Ameya Mahabaleshwarkar <ameyasm1154@gmail.com>
@ameyasm1154 ameyasm1154 requested a review from Zhilin123 July 25, 2022 20:10
Copy link
Collaborator

@Zhilin123 Zhilin123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit faf8ad8 into main Jul 26, 2022
@ericharper ericharper deleted the generative_qa_ci branch July 26, 2022 01:49
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
Signed-off-by: Ameya Mahabaleshwarkar <ameyasm1154@gmail.com>

Co-authored-by: Eric Harper <complex451@gmail.com>
Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: Ameya Mahabaleshwarkar <ameyasm1154@gmail.com>

Co-authored-by: Eric Harper <complex451@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants