Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DALI char dataset support to SSL model #4592

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

piraka9011
Copy link
Contributor

What does this PR do ?

Use DALI pipelines as part of ssl_models

Collection: ASR

Changelog

  • Add DALI char dataset support to SSL model

PR Type:

  • New Feature

Tested manually by running 1 validation step on a local dataset.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
Copy link
Contributor

@sam1373 sam1373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sam1373 sam1373 merged commit c324499 into NVIDIA:main Jul 25, 2022
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>

Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>

Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants