update fastpitch to add export controls #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason <jasoli@nvidia.com>
|
This pull request introduces 1 alert when merging 5df67cc into ad61479 - view on LGTM.com new alerts:
|
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
redoctopus
reviewed
Jul 14, 2022
redoctopus
approved these changes
Jul 14, 2022
itzsimpl
pushed a commit
to itzsimpl/NeMo
that referenced
this pull request
Jul 18, 2022
* update fastpitch to add export controls Signed-off-by: Jason <jasoli@nvidia.com> * final touchups Signed-off-by: Jason <jasoli@nvidia.com> * more final touchups Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: Iztok Lebar Bajec <ilb@fri.uni-lj.si>
arendu
pushed a commit
that referenced
this pull request
Jul 21, 2022
* update fastpitch to add export controls Signed-off-by: Jason <jasoli@nvidia.com> * final touchups Signed-off-by: Jason <jasoli@nvidia.com> * more final touchups Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: arendu <adithya.r@gmail.com>
Davood-M
pushed a commit
to Davood-M/NeMo
that referenced
this pull request
Aug 9, 2022
* update fastpitch to add export controls Signed-off-by: Jason <jasoli@nvidia.com> * final touchups Signed-off-by: Jason <jasoli@nvidia.com> * more final touchups Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* update fastpitch to add export controls Signed-off-by: Jason <jasoli@nvidia.com> * final touchups Signed-off-by: Jason <jasoli@nvidia.com> * more final touchups Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds options for fastpitch export. One for ragged_batch and one for volume. Undos the hard assumption that
volumemust be input and output as done in #4167Collection: TTS
Changelog
PR Type: