Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r1.9.0 main #4331

Merged
merged 46 commits into from
Jun 7, 2022
Merged

Merge r1.9.0 main #4331

merged 46 commits into from
Jun 7, 2022

Commits on Jun 3, 2022

  1. update branch 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    680b099 View commit details
    Browse the repository at this point in the history

  2. update package info 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    d25fa43 View commit details
    Browse the repository at this point in the history

  3. cleaned up TN/ ITN doc (#4119) 

    * cleaned up TN/ ITN doc

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* fix typo

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* fix image

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* fix image

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
    @yzhang123 @ericharper
    yzhang123 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    be2b7c9 View commit details
    Browse the repository at this point in the history

  4. Draft: Fix restoring from checkpoint for case when `model.common_data… 

    …set_parameters.label_vocab_dir` is provided (#4136)

* Fix restoring from checkpoint with label vocab dir

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Add tests for various ways to pass label ids to model

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Fix typo

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Fix typo

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Do not create tmp directory

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Fix parameter name

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* finish cherry-pick op

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Fix labels errors

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Remove duplicate stage

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Change target branch

Signed-off-by: PeganovAnton <peganoff2@mail.ru>
    @PeganovAnton @ericharper
    PeganovAnton authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    42f6a38 View commit details
    Browse the repository at this point in the history

  5. fix doc (#4146) 

    Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
    @yzhang123 @ericharper
    yzhang123 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    47c138c View commit details
    Browse the repository at this point in the history

  6. Tacotron2 retrain (#4103) 

    * fix yaml

Signed-off-by: treacker <emshabalin@yandex.ru>

* Fix for new TTSDataset class

Signed-off-by: treacker <emshabalin@yandex.ru>

* added wandb logging

Signed-off-by: treacker <emshabalin@yandex.ru>

* added wandb logging

Signed-off-by: treacker <emshabalin@yandex.ru>

* fix numpy version

Signed-off-by: treacker <emshabalin@yandex.ru>

* fix numpy version

Signed-off-by: treacker <emshabalin@yandex.ru>

* inference fix

Signed-off-by: treacker <emshabalin@yandex.ru>

* removed old code

Signed-off-by: treacker <emshabalin@yandex.ru>

* updated parser logic

Signed-off-by: treacker <emshabalin@yandex.ru>

* reverted version update

Signed-off-by: treacker <emshabalin@yandex.ru>

* refactored parser logic

Signed-off-by: treacker <emshabalin@yandex.ru>

* Updated Jenkinsfile

Signed-off-by: treacker <emshabalin@yandex.ru>

* Refactored tutorial for Tacotron2

Signed-off-by: treacker <emshabalin@yandex.ru>

* Made backward compatibility

Signed-off-by: treacker <emshabalin@yandex.ru>

* Made backward compatibility

Signed-off-by: treacker <emshabalin@yandex.ru>

* Update Jenkinsfile

Signed-off-by: treacker <emshabalin@yandex.ru>

* Update tacotron.yaml

Signed-off-by: treacker <emshabalin@yandex.ru>

* Refactoring

Signed-off-by: treacker <emshabalin@yandex.ru>

* cleaned up TN/ ITN doc (#4119)

* cleaned up TN/ ITN doc

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* fix typo

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* fix image

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* fix image

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
Signed-off-by: treacker <emshabalin@yandex.ru>

* Check implicit grad acc in GLUE dataset building (#4123)

* Check implicit grad acc in GLUE dataset building

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Fix jenkins test for GLUE/XNLI

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: treacker <emshabalin@yandex.ru>

* Refactoring

Signed-off-by: treacker <emshabalin@yandex.ru>

* Refactoring

Signed-off-by: treacker <emshabalin@yandex.ru>

* Fixed jenkins

Signed-off-by: treacker <emshabalin@yandex.ru>

* Refactoring

Signed-off-by: treacker <emshabalin@yandex.ru>

* Refactoring

Signed-off-by: treacker <emshabalin@yandex.ru>

* Refactoring

Signed-off-by: treacker <emshabalin@yandex.ru>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
    @treacker @yzhang123
    @MaximumEntropy @ericharper
    3 people authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b4699ac View commit details
    Browse the repository at this point in the history

  7. Multiprocess improvements (#4127) 

    * initial commit

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* start fix

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* improve multiprocessing speed while creating speaker dataset

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* updated scp to filelist

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
    @nithinraok @ericharper
    nithinraok authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    0e95b67 View commit details
    Browse the repository at this point in the history

  8. notebooks' link, typo and import fix (#4158) 

    * redo missing pr 4007

Signed-off-by: fayejf <fayejf07@gmail.com>

* remove extremely unreliable links

Signed-off-by: fayejf <fayejf07@gmail.com>
    @fayejf @ericharper
    fayejf authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    afca46a View commit details
    Browse the repository at this point in the history

  9. update speaker docs (#4164) 

    * update speaker docs

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* chunks -> segments

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>

* Khz -> kHz

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
    @nithinraok @ericharper
    nithinraok authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    f55c02b View commit details
    Browse the repository at this point in the history

  10. small fix (#4180) 

    Signed-off-by: fayejf <fayejf07@gmail.com>
    @fayejf @ericharper
    fayejf authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    d10f605 View commit details
    Browse the repository at this point in the history

  11. fix the server key value problem (#4196) 

    Signed-off-by: Yi Dong <yidong@nvidia.com>
    @yidong72 @ericharper
    yidong72 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    7872fc1 View commit details
    Browse the repository at this point in the history

  12. Fix/punctuation/trainer required for setting test data (#4199) 

    * Draft of fix

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Add warnings and replace globa_step with current_epoch

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Small improvements to warnings

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Error and warning messages improvements

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Replace self.trainer with self._trainer

Signed-off-by: PeganovAnton <peganoff2@mail.ru>
    @PeganovAnton @ericharper
    PeganovAnton authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ffc0744 View commit details
    Browse the repository at this point in the history

  13. Update ContextNet version (#4207) 

    Signed-off-by: smajumdar <smajumdar@nvidia.com>
    @titu1994 @ericharper
    titu1994 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    5a33417 View commit details
    Browse the repository at this point in the history

  14. fix bugs for dialogue tutorial (#4211) 

    Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
    @Zhilin123 @ericharper
    Zhilin123 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    c9a5c1f View commit details
    Browse the repository at this point in the history

  15. Dialogue tutorial fix (#4214) 

    * fix bugs for dialogue tutorial

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* update path for convert_datasets.py due to conflict PR

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
    @Zhilin123 @ericharper
    Zhilin123 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    a5214a3 View commit details
    Browse the repository at this point in the history

  16. Add docs for Thutmose Tagger (#4173) 

    * Add docs for Thutmose Tagger

Signed-off-by: Alexandra Antonova <aleksandraa@nvidia.com>

* add level in docs

Signed-off-by: Alexandra Antonova <aleksandraa@nvidia.com>

* delete folder to avoid error with running when folder exists from previous run

Signed-off-by: Alexandra Antonova <aleksandraa@nvidia.com>

Co-authored-by: Alexandra Antonova <aleksandraa@nvidia.com>
Co-authored-by: ekmb <ebakhturina@nvidia.com>
    @bene-ges @ekmb @ericharper
    3 people authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    871ad0c View commit details
    Browse the repository at this point in the history

  17. Dialogue tutorial fix (#4218) 

    * fix bugs for dialogue tutorial

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* update path for convert_datasets.py due to conflict PR

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* restore previously deleted files

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* style fix

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
    @Zhilin123 @ericharper
    Zhilin123 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    4e05ce5 View commit details
    Browse the repository at this point in the history

  18. Dialogue tutorial fix (#4221) 

    * fix bugs for dialogue tutorial

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* update path for convert_datasets.py due to conflict PR

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* restore previously deleted files

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* style fix

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>

* update tutorial

Signed-off-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
    @Zhilin123 @ericharper
    Zhilin123 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ea411b9 View commit details
    Browse the repository at this point in the history

  19. fix syntax error in ipynb-file (#4228) 

    Signed-off-by: Alexandra Antonova <aleksandraa@nvidia.com>

Co-authored-by: Alexandra Antonova <aleksandraa@nvidia.com>
    @bene-ges @ericharper
    2 people authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    778ca15 View commit details
    Browse the repository at this point in the history

  20. fix json serialize (#4235) 

    Signed-off-by: Yi Dong <yidong@nvidia.com>
    @yidong72 @ericharper
    yidong72 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    76111d9 View commit details
    Browse the repository at this point in the history

  21. Prompt Learning Typo Fixes (#4238) 

    * Prompt tuning notebook typo fixes

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Update tutorials.rst

* Update prompt_learning.rst

* Update prompt_learning.rst
    @vadam5 @ericharper
    vadam5 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    524d584 View commit details
    Browse the repository at this point in the history

  22. fixing bug 3642622 (#4250) 

    * fixing bug 3642622

Signed-off-by: Ghasem Pasandi <gpasandi@nvidia.com>

* fixing bug 3642622

Signed-off-by: Ghasem Pasandi <gpasandi@nvidia.com>

Co-authored-by: Ghasem Pasandi <gpasandi@nvidia.com>
    @pasandi20 @ericharper
    2 people authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    8c26234 View commit details
    Browse the repository at this point in the history

  23. fix broken link in the tutorial (#4257) 

    Signed-off-by: Alexandra Antonova <aleksandraa@nvidia.com>

Co-authored-by: Alexandra Antonova <aleksandraa@nvidia.com>
    @bene-ges @ericharper
    2 people authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    33c4202 View commit details
    Browse the repository at this point in the history

  24. Typo fix, branch change, better download messagae (#4262) 

    Signed-off-by: Virginia Adams <vadams@nvidia.com>
    @vadam5 @ericharper
    vadam5 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    274a396 View commit details
    Browse the repository at this point in the history

  25. Raise error if bicleaner is not installed in NMT Data preprocesing no… 

    …tebook (#4264)

* Raise error if bicleaner is not installed

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Clear cells

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
    @MaximumEntropy @ericharper
    MaximumEntropy authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    56dd272 View commit details
    Browse the repository at this point in the history

  26. Fix missing validation dataset, whitelist certain keywords for datase… 

    …ts (#4269)

* Fix missing validation dataset, whitelist certain keywords for datasets

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix missing validation dataset, whitelist certain keywords for datasets

Signed-off-by: smajumdar <smajumdar@nvidia.com>
    @titu1994 @ericharper
    titu1994 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b02748e View commit details
    Browse the repository at this point in the history

  27. Update asr configs with num_workers and pin_memory (#4270) 

    Signed-off-by: smajumdar <smajumdar@nvidia.com>
    @titu1994 @ericharper
    titu1994 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    59f1ddf View commit details
    Browse the repository at this point in the history

  28. Fix epoch end (#4265) 

    Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

Co-authored-by: Eric Harper <complex451@gmail.com>
    @MaximumEntropy @ericharper
    MaximumEntropy and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    112fbf4 View commit details
    Browse the repository at this point in the history

  29. Set Save on train end to false (#4274) 

    * Set Save on train end to false

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Update prompt_learning.rst

* Update prompt_learning.rst
    @vadam5 @ericharper
    vadam5 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    c84a3df View commit details
    Browse the repository at this point in the history

  30. Update YAML (#4261) 

    Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
    @MaximumEntropy @ericharper
    MaximumEntropy authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    65a72be View commit details
    Browse the repository at this point in the history

  31. Updated config to fix CI test OOM error (#4279) 

    * Updated config to fix CI test issue

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Increased num workers

Signed-off-by: Virginia Adams <vadams@nvidia.com>
    @vadam5 @ericharper
    vadam5 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    dfdb10c View commit details
    Browse the repository at this point in the history

  32. verbose k2 install, skip if failed (#4289) 

    Signed-off-by: Aleksandr Laptev <alaptev@nvidia.com>

Co-authored-by: Aleksandr Laptev <alaptev@nvidia.com>
    @GNroy @ericharper
    2 people authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ea798df View commit details
    Browse the repository at this point in the history

  33. Changed total virtual prompt tokens (#4295) 

    * Changed total virtual prompt tokens

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* put number of workers back

Signed-off-by: Virginia Adams <vadams@nvidia.com>
    @vadam5 @ericharper
    vadam5 authored and ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    7005667 View commit details
    Browse the repository at this point in the history

  34. upper bound lightning 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    7e14b13 View commit details
    Browse the repository at this point in the history

  35. update branch 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    304856f View commit details
    Browse the repository at this point in the history

  36. update config 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    be63728 View commit details
    Browse the repository at this point in the history

  37. remove duplicate test 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    a280fca View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Merge branch 'main' into merge_r1.9.0_main

    @vadam5
    vadam5 authored Jun 5, 2022
    Configuration menu
    Copy the full SHA
    4d0b79b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Merge branch 'main' into merge_r1.9.0_main

    @ericharper
    ericharper authored Jun 6, 2022
    Configuration menu
    Copy the full SHA
    68eaac2 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. fix tn test cases 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    dc4bc08 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'merge_r1.9.0_main' of github.com:NVIDIA/NeMo into merge… 

    …_r1.9.0_main
    @ericharper
    ericharper committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    ace5750 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into merge_r1.9.0_main

    @ericharper
    ericharper authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    6d719a9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into merge_r1.9.0_main

    @ericharper
    ericharper authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3d84c14 View commit details
    Browse the repository at this point in the history

  5. add another safe.directory 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    e3c9559 View commit details
    Browse the repository at this point in the history

  6. typo 

    Signed-off-by: ericharper <complex451@gmail.com>
    @ericharper
    ericharper committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d55f765 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into merge_r1.9.0_main

    @ericharper
    ericharper authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    fd070b1 View commit details
    Browse the repository at this point in the history