Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freesound fixes #4155

Merged
merged 2 commits into from
May 20, 2022
Merged

Freesound fixes #4155

merged 2 commits into from
May 20, 2022

Conversation

virajkarandikar
Copy link
Contributor

@virajkarandikar virajkarandikar commented May 12, 2022

What does this PR do ?

Fixes freesound-python git path and updates filename cleanup

Collection: [Note which collection this PR will affect]

Changelog

  • Update requirements.txt to use https instead of git to fix "The unauthenticated git protocol on port 9418 is no longer supported."
  • Remove additional characters from filename

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@titu1994 titu1994 requested a review from fayejf May 12, 2022 04:51
fayejf
fayejf previously approved these changes May 12, 2022
Copy link
Collaborator

@fayejf fayejf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@virajkarandikar
Copy link
Contributor Author

Fixed missing signed-off in commit message.

titu1994
titu1994 previously approved these changes May 17, 2022
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Update requirements.txt to use https instead of git to fix below error.

The unauthenticated git protocol on port 9418 is no longer supported.

Signed-off-by: Viraj Karandikar <vkarandikar@nvidia.com>
Remove additional characters from filename

Signed-off-by: Viraj Karandikar <vkarandikar@nvidia.com>
@titu1994 titu1994 merged commit cfcb5f6 into NVIDIA:main May 20, 2022
@virajkarandikar virajkarandikar deleted the freesound_fixes branch May 20, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants