fix error #4120
Merged
fix error #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
ekmb
reviewed
May 6, 2022
| @@ -31,7 +31,7 @@ | |||
| "metadata": {}, | |||
| "source": [ | |||
| "# Overview\n", | |||
| "<img src=\"https://raw.githubusercontent.com/NVIDIA/NeMo/tn_tutorial/tutorials/text_processing/images/task_overview.png\" width=\"600\"/>" | |||
| "<img src=\"https://raw.githubusercontent.com/NVIDIA/NeMo/main/tutorials/text_processing/images/task_overview.png\" width=\"600\"/>" | |||
There was a problem hiding this comment.
the image is not found if i use stable
ekmb
approved these changes
May 6, 2022
stevehuang52
pushed a commit
to stevehuang52/NeMo
that referenced
this pull request
May 9, 2022
* fix error Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com>
titu1994
pushed a commit
that referenced
this pull request
May 9, 2022
* Tn tutorial (#4090) * refactor tn data folder, and update of measure Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * udpate jenkins Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added whitelist with spaces for asr Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * save Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * save Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * electronic updated Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added file support Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add ip prompt Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add missing file Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update grammars Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix header Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fixed electronic review added ssn Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * udpated money Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added more formats for year range Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix pytest Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * style fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove run predict Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add images Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add images Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove redundant notebook Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove readme Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * change requirement name for tn Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * updated wfst tut Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added final notes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added final notes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * redirect readme Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove files Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * deleted redundant docs Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * finished deployment docs Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix style Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update tutorials Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add more test cases Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add link Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * lgtm Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * sort imports Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * changed to language support matrix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * changed to language support matrix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix branch Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com> * fix error (#4120) * fix error Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> * Fix restoring from checkpoint for case when `model.common_dataset_parameters.label_vocab_dir` is provided (#3562) * Fix RANK env variable check in global rank check Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix restoring from checkpoint with label vocab dir Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Add tests for various ways to pass label ids to model Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix typo Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix typo Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Do not create tmp directory Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix parameter name Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Try CUDA launch blocking Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix labels errors Signed-off-by: PeganovAnton <peganoff2@mail.ru> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Co-authored-by: PeganovAnton <peganoff2@mail.ru> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
yidong72
pushed a commit
that referenced
this pull request
May 12, 2022
* fix error Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: Yi Dong <yidong@nvidia.com>
yidong72
pushed a commit
that referenced
this pull request
May 12, 2022
* Tn tutorial (#4090) * refactor tn data folder, and update of measure Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * udpate jenkins Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added whitelist with spaces for asr Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * save Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * save Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * electronic updated Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added file support Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add ip prompt Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add missing file Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update grammars Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix header Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fixed electronic review added ssn Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * udpated money Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added more formats for year range Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix pytest Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * style fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove run predict Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add images Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add images Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove redundant notebook Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove readme Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * change requirement name for tn Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * updated wfst tut Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added final notes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added final notes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * redirect readme Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove files Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * deleted redundant docs Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * finished deployment docs Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix style Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update tutorials Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add more test cases Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add link Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * lgtm Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * sort imports Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * changed to language support matrix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * changed to language support matrix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix branch Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com> * fix error (#4120) * fix error Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> * Fix restoring from checkpoint for case when `model.common_dataset_parameters.label_vocab_dir` is provided (#3562) * Fix RANK env variable check in global rank check Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix restoring from checkpoint with label vocab dir Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Add tests for various ways to pass label ids to model Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix typo Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix typo Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Do not create tmp directory Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix parameter name Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Try CUDA launch blocking Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix labels errors Signed-off-by: PeganovAnton <peganoff2@mail.ru> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Co-authored-by: PeganovAnton <peganoff2@mail.ru> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: Yi Dong <yidong@nvidia.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
May 13, 2022
* Tn tutorial (NVIDIA#4090) * refactor tn data folder, and update of measure Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * udpate jenkins Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added whitelist with spaces for asr Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * save Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * save Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * electronic updated Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added file support Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add ip prompt Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add missing file Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update grammars Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix header Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fixed electronic review added ssn Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * udpated money Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added more formats for year range Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix pytest Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * style fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove run predict Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add images Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add images Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove redundant notebook Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove readme Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * change requirement name for tn Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * updated wfst tut Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added final notes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added final notes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * redirect readme Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove files Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * deleted redundant docs Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * finished deployment docs Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix style Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update tutorials Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add more test cases Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * remove image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add link Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * lgtm Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * sort imports Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * changed to language support matrix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * changed to language support matrix Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix branch Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com> * fix error (NVIDIA#4120) * fix error Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * update image Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> * Fix restoring from checkpoint for case when `model.common_dataset_parameters.label_vocab_dir` is provided (NVIDIA#3562) * Fix RANK env variable check in global rank check Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix restoring from checkpoint with label vocab dir Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Add tests for various ways to pass label ids to model Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix typo Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix typo Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Do not create tmp directory Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix parameter name Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Try CUDA launch blocking Signed-off-by: PeganovAnton <peganoff2@mail.ru> * Fix labels errors Signed-off-by: PeganovAnton <peganoff2@mail.ru> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Co-authored-by: PeganovAnton <peganoff2@mail.ru> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Zhang yangzhang@nvidia.com