Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMT GRPC sever URL fix #3918

Merged
merged 6 commits into from
Mar 31, 2022
Merged

NMT GRPC sever URL fix #3918

merged 6 commits into from
Mar 31, 2022

Conversation

MaximumEntropy
Copy link
Contributor

What does this PR do ?

Makes server URL generic for NMT GRPC and not specific to being on localhost

Collection: Tools

Changelog

  • Accept server URL directly instead of just a localhost port in client.py

Usage

python tools/nmt_grpc_service/client.py --source_language en --target_language de --text "This is a sentence." --server_url 1.1.1.1:50052

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
@MaximumEntropy MaximumEntropy requested a review from aklife97 March 31, 2022 20:29
Copy link
Collaborator

@aklife97 aklife97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aklife97 aklife97 merged commit b1b6e5e into main Mar 31, 2022
@aklife97 aklife97 deleted the nmt_grpc_client_uri branch March 31, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants