Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Japanese processor for NMT that uses MeCab segmentation. Fix for BLEU in one-many NMT #3889

Merged
merged 18 commits into from
Mar 30, 2022

Conversation

MaximumEntropy
Copy link
Contributor

What does this PR do ?

  1. It implements a processor JaMeCabProcessor to train and evaluate models where Japanese is segmented with MeCab
  2. Fixes a bug in one-many translation BLEU score eval. Old code would not index into self.tgt_language to select the appropriate language.

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
@MaximumEntropy MaximumEntropy requested a review from aklife97 March 26, 2022 08:05
Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>
aklife97
aklife97 previously approved these changes Mar 28, 2022
Copy link
Collaborator

@aklife97 aklife97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@MaximumEntropy MaximumEntropy merged commit 84236ba into main Mar 30, 2022
@MaximumEntropy MaximumEntropy deleted the iwslt_22 branch March 30, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants