-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel prompt tuning #3670
Parallel prompt tuning #3670
Conversation
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 9 alerts and fixes 1 when merging 02d395a into aeeb0d2 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 9 alerts and fixes 1 when merging 9381c4c into b98a07d - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request fixes 1 alert when merging a31a264 into b5012d0 - view on LGTM.com fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 1 alert and fixes 1 when merging 59af92b into 2ebca22 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 1 when merging a8a2c3b into 8ffc92e - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 3 alerts and fixes 1 when merging 8be857f into c00bcd6 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 3 alerts and fixes 1 when merging 724773f into 6dd4263 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 3 alerts and fixes 1 when merging 085d2ed into 6dd4263 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 1 alert and fixes 1 when merging 44f6e22 into 6dd4263 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 1 alert and fixes 1 when merging 901c9ee into 1b89a70 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 1 alert and fixes 1 when merging f5c2b6e into 1b89a70 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Virginia Adams <vadams@nvidia.com>
This pull request introduces 1 alert and fixes 3 when merging 312bcc4 into 1b89a70 - view on LGTM.com new alerts:
fixed alerts:
|
nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a couple of imports that you did not want to add, see the comments.
Signed-off-by: Virginia Adams <vadams@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This pull request fixes 3 alerts when merging 2667ad8 into 1b89a70 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Started combined tensor parallel and pipeline parallel changes Signed-off-by: Virginia Adams <vadams@nvidia.com> * Gets through validation sanity checks Signed-off-by: Virginia Adams <vadams@nvidia.com> * Still working through bugs Signed-off-by: Virginia Adams <vadams@nvidia.com> * Able to run training but virtual token parameters don't get updated Signed-off-by: Virginia Adams <vadams@nvidia.com> * params weren't updating because they weren't setup w/ optimizer Signed-off-by: Virginia Adams <vadams@nvidia.com> * Parallel with single GPU is working! Signed-off-by: Virginia Adams <vadams@nvidia.com> * Tensor parallel = 2 is working Signed-off-by: Virginia Adams <vadams@nvidia.com> * Tensor parallel working and code cleaned up Signed-off-by: Virginia Adams <vadams@nvidia.com> * Added prompt tuning testing back in Signed-off-by: Virginia Adams <vadams@nvidia.com> * Complete method works again for prompt tuned mdoels Signed-off-by: Virginia Adams <vadams@nvidia.com> * removed random imports Signed-off-by: Virginia Adams <vadams@nvidia.com>
What does this PR do ?
This PR fixes prompt tuning to work with the updated pipeline parallel code. In this PR a user can also prompt tune using tensor parallel > 1. More work will need to be done for prompt tuning to be supported for pipeline parallel > 1.
Collection: [Note which collection this PR will affect]
BigNLP?
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information