-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asr noise data scripts #3660
Asr noise data scripts #3660
Conversation
Signed-off-by: jbalam <jbalam@nvidia.com>
Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com>
This pull request introduces 4 alerts when merging 435ccfd into 461a866 - view on LGTM.com new alerts:
|
Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com>
… into asr_noise_data_scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but a few changes required. Also, the dataset scripts dir is going out of control in size. Need to refactor it in the future.
Signed-off-by: jbalam <jbalam@nvidia.com>
Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* new script to download and process demand data * Added script to add noise to an audio dataset Signed-off-by: jbalam <jbalam@nvidia.com> * Added license header and usage Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com> * Removed unused imports Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com> * style fix Signed-off-by: jbalam <jbalam@nvidia.com> * parametrized sample rate Signed-off-by: jbalam <jbalam@nvidia.com> * Addressed changes suggested in review Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com> * style fix Signed-off-by: jbalam <jbalam@nvidia.com>
What does this PR do ?
Adds scripts 1) download and prepare noise data from Demand database and 2) to add noise to an audio dataset at various SNRs
Collection: [ASR]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information