Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asr noise data scripts #3660

Merged
merged 15 commits into from
Feb 17, 2022
Merged

Asr noise data scripts #3660

merged 15 commits into from
Feb 17, 2022

Conversation

jbalam-nv
Copy link
Collaborator

What does this PR do ?

Adds scripts 1) download and prepare noise data from Demand database and 2) to add noise to an audio dataset at various SNRs
Collection: [ASR]

Changelog

  • Added script to download and prepare manifest for noise data from Demand noise database.
  • Added script to add noise to an audio dataset at various SNRs

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

jbalam-nv and others added 4 commits February 9, 2022 15:30
@lgtm-com
Copy link

lgtm-com bot commented Feb 14, 2022

This pull request introduces 4 alerts when merging 435ccfd into 461a866 - view on LGTM.com

new alerts:

  • 4 for Unused import

jbalam-nv and others added 5 commits February 13, 2022 21:42
Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com>
Signed-off-by: jbalam <jbalam@nvidia.com>
@jbalam-nv jbalam-nv requested a review from titu1994 February 15, 2022 20:01
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but a few changes required. Also, the dataset scripts dir is going out of control in size. Need to refactor it in the future.

scripts/dataset_processing/add_noise.py Outdated Show resolved Hide resolved
scripts/dataset_processing/add_noise.py Outdated Show resolved Hide resolved
scripts/dataset_processing/get_demand_data.py Show resolved Hide resolved
jbalam-nv and others added 6 commits February 15, 2022 15:56
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titu1994 titu1994 merged commit c00bcd6 into main Feb 17, 2022
@titu1994 titu1994 deleted the asr_noise_data_scripts branch February 17, 2022 01:50
fayejf pushed a commit that referenced this pull request Mar 2, 2022
* new script to download and process demand data

* Added script to add noise to an audio dataset

Signed-off-by: jbalam <jbalam@nvidia.com>

* Added license header and usage

Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com>

* Removed unused imports

Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com>

* style fix

Signed-off-by: jbalam <jbalam@nvidia.com>

* parametrized sample rate

Signed-off-by: jbalam <jbalam@nvidia.com>

* Addressed changes suggested in review

Signed-off-by: jbalam-nv <4916480+jbalam-nv@users.noreply.github.com>

* style fix

Signed-off-by: jbalam <jbalam@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants