Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Refactor #305

Merged
merged 12 commits into from
Feb 3, 2020
Merged

Logging Refactor #305

merged 12 commits into from
Feb 3, 2020

Conversation

blisc
Copy link
Collaborator

@blisc blisc commented Jan 28, 2020

Fixing #292 to work on top on of current release

Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2020

This pull request introduces 2 alerts when merging 2a3bbbe into cc6e97a - view on LGTM.com

new alerts:

  • 2 for Unused import

blisc added 2 commits January 28, 2020 16:44
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2020

This pull request introduces 2 alerts when merging 90d2b61 into 1fddca2 - view on LGTM.com

new alerts:

  • 2 for Unused import

blisc added 2 commits January 28, 2020 17:21
Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2020

This pull request introduces 2 alerts when merging 3bb0cdc into 1fddca2 - view on LGTM.com

new alerts:

  • 2 for Unused import

blisc added 2 commits January 28, 2020 17:32
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2020

This pull request introduces 2 alerts when merging 3807de7 into 1fddca2 - view on LGTM.com

new alerts:

  • 2 for Unused import

blisc added 2 commits January 30, 2020 15:45
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 30, 2020

This pull request introduces 2 alerts when merging 08b1eed into 1fddca2 - view on LGTM.com

new alerts:

  • 2 for Unused import

@blisc blisc mentioned this pull request Jan 31, 2020
@blisc blisc changed the title [WIP] Logging Refactor Logging Refactor Feb 3, 2020
Signed-off-by: Jason <jasoli@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 3, 2020

This pull request introduces 2 alerts when merging 0cbcc8c into 288ea3d - view on LGTM.com

new alerts:

  • 2 for Unused import

Signed-off-by: Jason <jasoli@nvidia.com>
@blisc blisc requested review from okuchaiev and yzhang123 February 3, 2020 22:30
Signed-off-by: Jason <jasoli@nvidia.com>
@@ -0,0 +1,50 @@
# Copyright (C) NVIDIA CORPORATION. All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these constants look like logging only constants. Should we rename the file to reflect that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that we can put environment variables and other Nemo constants into this file as the project progresses

@blisc blisc merged commit 54d68ab into NVIDIA:master Feb 3, 2020
@blisc blisc deleted the u_logging_update_3 branch February 5, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants