-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging Refactor #305
Logging Refactor #305
Conversation
Signed-off-by: Jason <jasoli@nvidia.com>
This pull request introduces 2 alerts when merging 2a3bbbe into cc6e97a - view on LGTM.com new alerts:
|
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
This pull request introduces 2 alerts when merging 90d2b61 into 1fddca2 - view on LGTM.com new alerts:
|
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
This pull request introduces 2 alerts when merging 3bb0cdc into 1fddca2 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 3807de7 into 1fddca2 - view on LGTM.com new alerts:
|
Signed-off-by: Jason <jasoli@nvidia.com>
This pull request introduces 2 alerts when merging 08b1eed into 1fddca2 - view on LGTM.com new alerts:
|
Signed-off-by: Jason <jasoli@nvidia.com>
This pull request introduces 2 alerts when merging 0cbcc8c into 288ea3d - view on LGTM.com new alerts:
|
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
@@ -0,0 +1,50 @@ | |||
# Copyright (C) NVIDIA CORPORATION. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these constants look like logging only constants. Should we rename the file to reflect that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is that we can put environment variables and other Nemo constants into this file as the project progresses
Fixing #292 to work on top on of current release