deprecated test case (NeuralFactory) + important bugfix! (v3) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tkornuta-nvidia
commented
Jan 27, 2020
tkornuta-nvidia
commented
- bugfix: decodator now also returns the result of the function (!)
- several NeuralFactory methods indicated as deprecated
- added init to decorators
Signed-off-by: nvidia <tkornuta@nvidia.com>
Signed-off-by: nvidia <tkornuta@nvidia.com>
Signed-off-by: nvidia <tkornuta@nvidia.com>
Signed-off-by: nvidia <tkornuta@nvidia.com>
|
This pull request fixes 3 alerts when merging c0f53b8 into d9fe6eb - view on LGTM.com fixed alerts:
|
Signed-off-by: nvidia <tkornuta@nvidia.com>
|
This pull request fixes 3 alerts when merging 068d9d9 into d9fe6eb - view on LGTM.com fixed alerts:
|
blisc
approved these changes
Jan 27, 2020
dcurran90
pushed a commit
to dcurran90/NeMo
that referenced
this pull request
Oct 15, 2024
* README: Lab requires python3 devel headers/library
The python3 development headers and library are required, or else
llama-cpp-python fails to build.
× Building wheel for llama-cpp-python (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [23 lines of output]
*** scikit-build-core 0.8.2 using CMake 3.28.3 (wheel)
*** Configuring CMake...
2024-03-05 11:42:14,297 - scikit_build_core - WARNING - libdir/ldlibrary: /usr/lib64/libpython3.12.so is not a real file!
2024-03-05 11:42:14,297 - scikit_build_core - WARNING - Can't find a Python library, got libdir=/usr/lib64, ldlibrary=libpython3.12.so, multiarch=x86_64-linux-gnu, masd=None
Signed-off-by: Stef Walter <stefw@redhat.com>
* README: Add gh tool install command on Fedora Linux
This is required to download the model.
Signed-off-by: Stef Walter <stefw@redhat.com>
* README: Command to install the g++ compiler on Fedora Linux
Add the command to install the g++ compiler on Fedora Linux. Otherwise
we get an error similar to the following when building llama-cpp-python
× Building wheel for llama-cpp-python (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [21 lines of output]
*** scikit-build-core 0.8.2 using CMake 3.28.3 (wheel)
*** Configuring CMake...
loading initial cache file /tmp/tmppdxr1vom/build/CMakeInit.txt
-- The C compiler identification is GNU 14.0.1
-- The CXX compiler identification is unknown
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at CMakeLists.txt:3 (project):
No CMAKE_CXX_COMPILER could be found.
Signed-off-by: Stef Walter <stefw@redhat.com>
---------
Signed-off-by: Stef Walter <stefw@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.