-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest refactor #284
Manifest refactor #284
Conversation
This pull request introduces 1 alert and fixes 3 when merging 00a9d59 into bc0d7b1 - view on LGTM.com new alerts:
fixed alerts:
|
Why did you request a review for a WIP PR? |
The new classes inside manifests.py are not very intuitive to me. It's hard for me to understand what you are trying to do with them at first glance. |
So you can comment on draft. Now I know what's need to fixed first. |
00a9d59
to
8a22b19
Compare
Sorry, I have to force-push commits to re-sign them after rebasing. |
This pull request fixes 4 alerts when merging 8a22b19 into 7779728 - view on LGTM.com fixed alerts:
|
This pull request introduces 1 alert and fixes 4 when merging 59ba6c9 into 7779728 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just import orders
This pull request fixes 4 alerts when merging 37d99b2 into 7779728 - view on LGTM.com fixed alerts:
|
This pull request fixes 4 alerts when merging 410dbba into 7779728 - view on LGTM.com fixed alerts:
|
410dbba
to
1caaef0
Compare
Signed-off-by: Stanislav Beliaev <stasbelyaev96@gmail.com>
1caaef0
to
5c9b906
Compare
Signed-off-by: Stanislav Beliaev <stasbelyaev96@gmail.com>
Signed-off-by: Stanislav Beliaev <stasbelyaev96@gmail.com>
Signed-off-by: Stanislav Beliaev <stasbelyaev96@gmail.com>
Signed-off-by: Stanislav Beliaev <stasbelyaev96@gmail.com>
Signed-off-by: Stanislav Beliaev <stasbelyaev96@gmail.com>
This pull request fixes 4 alerts when merging 5c9b906 into 30db6f2 - view on LGTM.com fixed alerts:
|
Old usage:
New usage: