Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeMo 1.0: upcycle dense to moe #11002

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Oct 23, 2024

What does this PR do ?

python3 upcycle_dense_to_moe.py --model ../mistral_2l_extracted/ --num-experts 8 --output-path what-moe

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Oct 23, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/upcycle_dense_to_moe branch from 11afd6d to 5e621b8 Compare October 23, 2024 06:30
@akoumpa akoumpa changed the title upcycle dense to moe NeMo 1.0: upcycle dense to moe Oct 23, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/upcycle_dense_to_moe branch from 68481f9 to 1e4f91a Compare October 23, 2024 16:41
akoumpa and others added 2 commits October 23, 2024 16:41
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa requested a review from ethanhe42 October 24, 2024 01:00
Copy link
Member

@ethanhe42 ethanhe42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

[🤖]: Hi @akoumpa 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@akoumpa akoumpa marked this pull request as ready for review October 30, 2024 01:40
@akoumpa akoumpa merged commit a8fd3d6 into main Oct 30, 2024
157 of 158 checks passed
@akoumpa akoumpa deleted the akoumparouli/upcycle_dense_to_moe branch October 30, 2024 01:40
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* upcycle dense to moe

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix(?) path when saving

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* bot happy

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* bot happy NVIDIA#2

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* add unwrap method

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

* move file

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
* upcycle dense to moe

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix(?) path when saving

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* bot happy

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* bot happy NVIDIA#2

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* add unwrap method

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

* move file

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* upcycle dense to moe

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix(?) path when saving

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* bot happy

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* bot happy xuanzic#2

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* add unwrap method

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

* move file

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants