Call ckpt_to_weights_subdir from MegatronCheckpointIO
#10897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
akoumpa
reviewed
Oct 16, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -8,7 +8,7 @@ | |||
| from filelock import FileLock, Timeout | |||
| from pytorch_lightning.trainer.states import TrainerFn | |||
|
|
|||
| from nemo.lightning.ckpt_utils import ckpt_to_context_subdir, ckpt_to_weights_subdir | |||
| from nemo.lightning.ckpt_utils import ckpt_to_context_subdir | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
|
[🤖]: Hi @ashors1 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
| @@ -37,7 +37,7 @@ | |||
| from torch import nn | |||
| from typing_extensions import Self, override | |||
|
|
|||
| from nemo.lightning.ckpt_utils import ckpt_to_dir | |||
| from nemo.lightning.ckpt_utils import WEIGHTS_PATH, ckpt_to_dir | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
Signed-off-by: Chen Cui <chcui@nvidia.com>
|
peft test passed https://github.com/NVIDIA/NeMo/actions/runs/11672168085/job/32500417335 launching full ci now |
cuichenx
approved these changes
Nov 5, 2024
|
[🤖]: Hi @ashors1 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
lilyw97
pushed a commit
to lilyw97/NeMo
that referenced
this pull request
Nov 13, 2024
* locate weights path within MegatronCheckpointIO Signed-off-by: ashors1 <ashors@nvidia.com> * small refactor Signed-off-by: ashors1 <ashors@nvidia.com> * remove another instance of ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * move ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> * add weights path in save_checkpoint Signed-off-by: ashors1 <ashors@nvidia.com> * fix circular import Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * handle saving in ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * fix minor typo Signed-off-by: ashors1 <ashors@nvidia.com> * bug fixes Signed-off-by: ashors1 <ashors@nvidia.com> * fix undefined variable Signed-off-by: ashors1 <ashors@nvidia.com> * move function Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * fix adapter meta file path Signed-off-by: Chen Cui <chcui@nvidia.com> * Apply isort and black reformatting Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> * fix mixtral test Signed-off-by: ashors1 <ashors@nvidia.com> * fix mixtral test Signed-off-by: ashors1 <ashors@nvidia.com> * use function for weights subdir Signed-off-by: Chen Cui <chcui@nvidia.com> * address comments Signed-off-by: ashors1 <ashors@nvidia.com> * move asserts Signed-off-by: ashors1 <ashors@nvidia.com> * fix undefined vars Signed-off-by: ashors1 <ashors@nvidia.com> * bug fix Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: ashors1 <ashors1@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: ashors1 <ashors1@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com>
HuiyingLi
pushed a commit
to HuiyingLi/NeMo
that referenced
this pull request
Nov 15, 2024
* locate weights path within MegatronCheckpointIO Signed-off-by: ashors1 <ashors@nvidia.com> * small refactor Signed-off-by: ashors1 <ashors@nvidia.com> * remove another instance of ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * move ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> * add weights path in save_checkpoint Signed-off-by: ashors1 <ashors@nvidia.com> * fix circular import Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * handle saving in ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * fix minor typo Signed-off-by: ashors1 <ashors@nvidia.com> * bug fixes Signed-off-by: ashors1 <ashors@nvidia.com> * fix undefined variable Signed-off-by: ashors1 <ashors@nvidia.com> * move function Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * fix adapter meta file path Signed-off-by: Chen Cui <chcui@nvidia.com> * Apply isort and black reformatting Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> * fix mixtral test Signed-off-by: ashors1 <ashors@nvidia.com> * fix mixtral test Signed-off-by: ashors1 <ashors@nvidia.com> * use function for weights subdir Signed-off-by: Chen Cui <chcui@nvidia.com> * address comments Signed-off-by: ashors1 <ashors@nvidia.com> * move asserts Signed-off-by: ashors1 <ashors@nvidia.com> * fix undefined vars Signed-off-by: ashors1 <ashors@nvidia.com> * bug fix Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: ashors1 <ashors1@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: ashors1 <ashors1@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com>
yashaswikarnati
pushed a commit
that referenced
this pull request
Nov 21, 2024
* locate weights path within MegatronCheckpointIO Signed-off-by: ashors1 <ashors@nvidia.com> * small refactor Signed-off-by: ashors1 <ashors@nvidia.com> * remove another instance of ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * move ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: artbataev <artbataev@users.noreply.github.com> * add weights path in save_checkpoint Signed-off-by: ashors1 <ashors@nvidia.com> * fix circular import Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * handle saving in ckpt_to_weights_subdir Signed-off-by: ashors1 <ashors@nvidia.com> * fix minor typo Signed-off-by: ashors1 <ashors@nvidia.com> * bug fixes Signed-off-by: ashors1 <ashors@nvidia.com> * fix undefined variable Signed-off-by: ashors1 <ashors@nvidia.com> * move function Signed-off-by: ashors1 <ashors@nvidia.com> * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * fix adapter meta file path Signed-off-by: Chen Cui <chcui@nvidia.com> * Apply isort and black reformatting Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> * fix mixtral test Signed-off-by: ashors1 <ashors@nvidia.com> * fix mixtral test Signed-off-by: ashors1 <ashors@nvidia.com> * use function for weights subdir Signed-off-by: Chen Cui <chcui@nvidia.com> * address comments Signed-off-by: ashors1 <ashors@nvidia.com> * move asserts Signed-off-by: ashors1 <ashors@nvidia.com> * fix undefined vars Signed-off-by: ashors1 <ashors@nvidia.com> * bug fix Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: ashors1 <ashors1@users.noreply.github.com> Signed-off-by: artbataev <artbataev@users.noreply.github.com> Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: ashors1 <ashors1@users.noreply.github.com> Co-authored-by: artbataev <artbataev@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information