Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ASR RNNT BPE model #10742

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix typo in ASR RNNT BPE model #10742

merged 1 commit into from
Oct 3, 2024

Conversation

pzelasko
Copy link
Collaborator

@pzelasko pzelasko commented Oct 3, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Piotr Żelasko <petezor@gmail.com>
@pzelasko pzelasko requested a review from nithinraok October 3, 2024 17:28
@github-actions github-actions bot added the ASR label Oct 3, 2024
@nithinraok nithinraok merged commit 1ce8639 into main Oct 3, 2024
12 of 13 checks passed
@nithinraok nithinraok deleted the fix-typo-asr branch October 3, 2024 17:29
Copy link
Contributor

@orena1 orena1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ko3n1g pushed a commit that referenced this pull request Oct 3, 2024
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
gdengk pushed a commit to gdengk/NeMo that referenced this pull request Oct 3, 2024
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Gao Deng <gdeng@nvidia.com>
gdengk pushed a commit to gdengk/NeMo that referenced this pull request Oct 3, 2024
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Gao Deng <gdeng@nvidia.com>
ko3n1g added a commit that referenced this pull request Oct 4, 2024
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Co-authored-by: Piotr Żelasko <petezor@gmail.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants