Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertion for always save nemo add model parallel size #10690

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

BoxiangW
Copy link
Collaborator

What does this PR do ?

always_save_nemo option is not supported yet to work with model parallel. Added assertions to avoid future confusions.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
@BoxiangW BoxiangW self-assigned this Sep 30, 2024
BoxiangW and others added 3 commits October 3, 2024 14:01
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>
@BoxiangW BoxiangW added Run CICD and removed Run CICD labels Oct 3, 2024
@maanug-nv
Copy link
Collaborator

maanug-nv commented Oct 4, 2024

Seems like we don't have the ability to save '.nemo' in 2.0 right?

@BoxiangW
Copy link
Collaborator Author

BoxiangW commented Oct 4, 2024

Yes, this was an NVbug about NeMo 1.0. We are not going to save .nemo in 2.0 right now

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
@maanug-nv
Copy link
Collaborator

One last request, can we add a test in test_exp_manager.py to ensure this configuration will fail?

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
@github-actions github-actions bot added the core Changes to NeMo Core label Oct 11, 2024
maanug-nv
maanug-nv previously approved these changes Oct 14, 2024
Copy link
Collaborator

@maanug-nv maanug-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. good to merge if tests pass

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
@BoxiangW BoxiangW removed the Run CICD label Oct 15, 2024
@BoxiangW BoxiangW enabled auto-merge (squash) October 16, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants