Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require setuptools>=70 and update deprecated api #10659

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

thomasdhc
Copy link
Collaborator

What does this PR do ?

Require setuptools>=70 and update deprecated api

Collection: [nlp, multimodal]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>
Copy link
Contributor

[🤖]: Hi @thomasdhc 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

2 similar comments
Copy link
Contributor

[🤖]: Hi @thomasdhc 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

Copy link
Contributor

[🤖]: Hi @thomasdhc 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

Copy link
Contributor

[🤖]: Hi @thomasdhc 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

@thomasdhc thomasdhc merged commit fd78cc6 into main Sep 30, 2024
295 of 302 checks passed
@thomasdhc thomasdhc deleted the donghyukc/setuptool_70 branch September 30, 2024 16:43
thomasdhc added a commit that referenced this pull request Sep 30, 2024
* Require setuptools>=70 and update deprecated api

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>

---------

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: thomasdhc <thomasdhc@users.noreply.github.com>
pablo-garay pushed a commit that referenced this pull request Sep 30, 2024
* Require setuptools>=70 and update deprecated api



* Apply isort and black reformatting



---------

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: thomasdhc <thomasdhc@users.noreply.github.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Require setuptools>=70 and update deprecated api

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>

---------

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: thomasdhc <thomasdhc@users.noreply.github.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* Require setuptools>=70 and update deprecated api

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>

---------

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: thomasdhc <thomasdhc@users.noreply.github.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* Require setuptools>=70 and update deprecated api

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>

---------

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: thomasdhc <thomasdhc@users.noreply.github.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Require setuptools>=70 and update deprecated api

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>

---------

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: thomasdhc <thomasdhc@users.noreply.github.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: thomasdhc <thomasdhc@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants