Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Mcore commit to 90cd925ed0842afd709b4bf63c56ee889f03323e #10433

Closed
wants to merge 1 commit into from

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Sep 9, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@ko3n1g
Copy link
Collaborator

ko3n1g commented Sep 9, 2024

Hey @akoumpa , it’s not necessary to do this manually, we have a nightly job that attempt this bump too. If it failed, it means that NeMo isn’t compatible to Mcore ToT and someone needs to look into it

@ko3n1g
Copy link
Collaborator

ko3n1g commented Sep 9, 2024

#10423

@akoumpa
Copy link
Member Author

akoumpa commented Sep 9, 2024

@ko3n1g thanks I was not aware; I'll close this in favor of 10423 and look into fixing any issues remaining.

@akoumpa akoumpa closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants