Skip to content

Commit

Permalink
fix type checking
Browse files Browse the repository at this point in the history
Signed-off-by: Chen Cui <chcui@nvidia.com>
  • Loading branch information
cuichenx committed Apr 26, 2024
1 parent a79bad6 commit ac3e158
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions nemo/lightning/pytorch/strategies.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def __init__(
pipeline_model_parallel_size: int = 1,
virtual_pipeline_model_parallel_size: Optional[int] = None,
sequence_parallel: bool = False,
data_sampler: Optional[DataSampler] = None,
data_sampler: Optional['DataSampler'] = None,
parallel_devices: Optional[List[torch.device]] = None,
cluster_environment=None, # TODO: Add type-hint
checkpoint_io=None, # TODO: Add type-hint
Expand All @@ -72,7 +72,7 @@ def __init__(
)
self.no_ddp_communication_hook = no_ddp_communication_hook
self.megatron_callbacks = CallbackConnector()
self.data_sampler: Optional[DataSampler] = data_sampler
self.data_sampler: Optional['DataSampler'] = data_sampler
self.tensor_model_parallel_size = tensor_model_parallel_size
self.pipeline_model_parallel_size = pipeline_model_parallel_size
self.virtual_pipeline_model_parallel_size = virtual_pipeline_model_parallel_size
Expand Down

0 comments on commit ac3e158

Please sign in to comment.