Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for callbacks #83

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Bug fix for callbacks #83

merged 3 commits into from
Jul 21, 2023

Conversation

Siraj-Aizlewood
Copy link
Contributor

See relevant LangChain Pull Request:

langchain-ai/langchain#6858

Was getting the following error:

image

Fixed by by providing tags = [] and inheritable_tags = [] arguments in callbacks.py, giving:

logging_callback_manager_for_chain = AsyncCallbackManagerForChainRun(
    run_id=uuid.uuid4(),
    parent_run_id=None,
    handlers=handlers,
    inheritable_handlers=handlers,
    tags=[],
    inheritable_tags=[],
)

@Siraj-Aizlewood
Bug fix for Callbacks
a7964f2 
Was getting a

"BaseRunManager.__init__() missing 2 required keyword-only arugments: 'tags' and 'inheritable_tags'"

error.

AsyncCallbackManagerForChainRun inherits AsyncRunManager which inherits BaseRunManager which requires tags and inheritable_tags arguments. We can set these to empty lists.
@Siraj-Aizlewood
Undo changes
f3433ba
@Siraj-Aizlewood
Bug fix for Callbacks
2b577a8 
Was getting a

"BaseRunManager.__init__() missing 2 required keyword-only arugments: 'tags' and 'inheritable_tags'"

error.

AsyncCallbackManagerForChainRun inherits AsyncRunManager which inherits BaseRunManager which requires tags and inheritable_tags arguments. We can set these to empty lists.
@drazvan
Copy link
Collaborator

drazvan commented Jul 21, 2023

Thanks for the fix @Siraj-Aizlewood!

@drazvan drazvan merged commit 46b5bfa into NVIDIA:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siraj-Aizlewood @drazvan