Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new RAG Chatbot example with llamaGuard and Alignscore integration #720

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

abodhankar
Copy link

LlamaGuard Alignscore Integration with RAG

@abodhankar
Copy link
Author

@drazvan for review

@drazvan drazvan self-requested a review September 3, 2024 10:25
@drazvan drazvan self-assigned this Sep 3, 2024
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abodhankar!

Generally, looks good. However, there are a few issues to solve before we'd be able to merge:

  • currently there is no documentation
  • the code is not a bot, so it should not be placed under examples/bots
  • given there's also an ingestion part, this would be a better fit for a notebook; the notebook would explain the goal, the ingestion part, and then adding the guardrails; you can place it in examples/notebooks;
  • the config itself (without the python files) can be placed under examples/configs; the notebook can copy it from there;
  • including a 200 pages PDF in the repository is not recommended; can this be downloaded dynamically from somewhere? You can add this part to the notebook as well.
  • only one commit seems to be signed. Please configure signing the commits as per the contributing guidelines, and then rebase on top of the develop branch.
  • make sure you link to the documentation about setting up the AlignScore server.

I'll review again once the above points have been addressed.

@abodhankar abodhankar force-pushed the rag-llamaguard-alignscore branch 2 times, most recently from a49a29b to 75118dd Compare September 4, 2024 00:30
@abodhankar
Copy link
Author

@drazvan Made all the changes as per request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants