-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new RAG Chatbot example with llamaGuard and Alignscore integration #720
Open
abodhankar
wants to merge
11
commits into
NVIDIA:develop
Choose a base branch
from
abodhankar:rag-llamaguard-alignscore
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@drazvan for review |
drazvan
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @abodhankar!
Generally, looks good. However, there are a few issues to solve before we'd be able to merge:
- currently there is no documentation
- the code is not a bot, so it should not be placed under
examples/bots
- given there's also an ingestion part, this would be a better fit for a notebook; the notebook would explain the goal, the ingestion part, and then adding the guardrails; you can place it in
examples/notebooks
; - the config itself (without the python files) can be placed under
examples/configs
; the notebook can copy it from there; - including a 200 pages PDF in the repository is not recommended; can this be downloaded dynamically from somewhere? You can add this part to the notebook as well.
- only one commit seems to be signed. Please configure signing the commits as per the contributing guidelines, and then rebase on top of the
develop
branch. - make sure you link to the documentation about setting up the AlignScore server.
I'll review again once the above points have been addressed.
abodhankar
force-pushed
the
rag-llamaguard-alignscore
branch
2 times, most recently
from
September 4, 2024 00:30
a49a29b
to
75118dd
Compare
abodhankar
force-pushed
the
rag-llamaguard-alignscore
branch
from
September 6, 2024 18:48
a40b98d
to
eaf9496
Compare
@drazvan Made all the changes as per request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LlamaGuard Alignscore Integration with RAG