Fix LLMParams bug and add unit tests (fixes #158) #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the bug in the
LLMParams
class. The bug was causing incorrect handling of parameters that were not directly attributes of thellm
object but were present in themodel_kwargs
dictionary. It resolves #158.The changes ensure that if a parameter is not an attribute of
llm
, it checks ifllm
has an attributemodel_kwargs
. Ifmodel_kwargs
exists, it checks if the parameter is inmodel_kwargs
. If it is, it saves the original value and sets the new value. If it's not, it logs a warning and sets the new value.Upon exiting the context manager, the original parameters are restored correctly, whether they were direct attributes of
llm
or keys inmodel_kwargs
.In addition to the bug fix, this PR also enhances the unit tests to cover these cases.