Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix utf-8 encoding issue, add embedding_model configuration #54

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

yuekaizhang
Copy link
Contributor

  1. fix 'utf-8' encoding issue for *.co and *.yml: to better support examples using prompts with different languages
  2. configure embedding model through config.yaml, such that we could use multilingual embedding model

@drazvan drazvan self-assigned this Jun 30, 2023
@drazvan
Copy link
Collaborator

drazvan commented Jun 30, 2023

Thanks for this @yuekaizhang! Looks good 👍 . Could you please sign the commit and force-push the branch again? (https://github.com/NVIDIA/NeMo-Guardrails/blob/main/CONTRIBUTING.md#signing-your-work). If you're able to do this in the next few hours, we can merge it as part of the 0.3.0 release, which is today.

The only thing missing is a mention in the documentation in the Configuration Guide, but I'm happy to add that myself.

@yuekaizhang
Copy link
Contributor Author

yuekaizhang commented Jun 30, 2023

Thanks for this @yuekaizhang! Looks good 👍 . Could you please sign the commit and force-push the branch again? (https://github.com/NVIDIA/NeMo-Guardrails/blob/main/CONTRIBUTING.md#signing-your-work). If you're able to do this in the next few hours, we can merge it as part of the 0.3.0 release, which is today.

The only thing missing is a mention in the documentation in the Configuration Guide, but I'm happy to add that myself.

I am happy to finish that now. However, I have already tried git commit -s -m "". I was wondering how to fix. @drazvan

@yuekaizhang
Copy link
Contributor Author

image

@drazvan
Copy link
Collaborator

drazvan commented Jun 30, 2023

You can checkout this guide from GitLab: https://docs.gitlab.com/ee/user/project/repository/gpg_signed_commits/. And make sure you add the generated GPG key to your GitHub account. To resign the commit, since there's only one, the easiest way is to make it again i.e. git reset HEAD~1 and the git commit -m "...". Make sure you run git config --global commit.gpgsign true beforehand so that all commits get signed automatically.

@yuekaizhang
Copy link
Contributor Author

You can checkout this guide from GitLab: https://docs.gitlab.com/ee/user/project/repository/gpg_signed_commits/. And make sure you add the generated GPG key to your GitHub account. To resign the commit, since there's only one, the easiest way is to make it again i.e. git reset HEAD~1 and the git commit -m "...". Make sure you run git config --global commit.gpgsign true beforehand so that all commits get signed automatically.

Many thanks. Done.

@drazvan drazvan merged commit fa3d65e into NVIDIA:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants