Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host Solver workspace query fix #733

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Host Solver workspace query fix #733

merged 2 commits into from
Aug 26, 2024

Conversation

aayushg55
Copy link
Contributor

  • Fix for LAPACK bug causing incorrect workspace size calculations for single-precision routines at large matrix sizes due to float-to-int conversions (only those that may need O(n^2) space like Eig and SVD are affected)
  • Removed caching in Host LU and Cholesky since no workspace is required

Misc: Renamed Host solver cache types to be lowercase for consistency

@aayushg55 aayushg55 requested a review from cliffburdick August 22, 2024 23:24
@cliffburdick
Copy link
Collaborator

/build

@cliffburdick cliffburdick merged commit baae78f into main Aug 26, 2024
1 check passed
@cliffburdick cliffburdick deleted the host_workspace branch August 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants