nsys-jax: time-alignment and lock-step analysis #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
force-pushed
the
olupton/multinode-nsys-jax
branch
from
63cec89
to
cba5ee7
Compare
olupton
force-pushed
the
olupton/multinode-nsys-jax
branch
from
cba5ee7
to
3a31ad4
Compare
gspschmid
previously approved these changes
Jul 3, 2024
.github/container/jax_nsys/python/jax_nsys/jax_nsys/analysis.py
Outdated
Show resolved
Hide resolved
.github/container/jax_nsys/python/jax_nsys/jax_nsys/analysis.py
Outdated
Show resolved
Hide resolved
Also: - use "device" instead of "rank" everywhere - move warmup removal heuristics to standalone function
olupton
force-pushed
the
olupton/multinode-nsys-jax
branch
from
3a31ad4
to
e923364
Compare
gspschmid
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: