Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mgmn workflow to PAX Rosetta #206

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Add mgmn workflow to PAX Rosetta #206

merged 4 commits into from
Sep 5, 2023

Conversation

maanug-nv
Copy link
Contributor

  • Adds pax MGMN tests (_test_pax.yaml) to Rosetta PAX build and test workflow
  • Routes pass/fail status of completion, perf, loss to badge and workflow output
  • add error message to asserts for perf+loss tests

yhtang
yhtang previously approved these changes Sep 1, 2023
Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhtang
Copy link
Collaborator

yhtang commented Sep 1, 2023

@maanug-nv Someone brought it up earlier and I wanna confirm here: does the merge button become clickable for you once it gets enough approvals?

@maanug-nv
Copy link
Contributor Author

Yeah, I can click merge now that you have approved

@maanug-nv
Copy link
Contributor Author

maanug-nv commented Sep 1, 2023

added one more thing, should use the new badge in README

Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maanug-nv maanug-nv merged commit 632b622 into main Sep 5, 2023
54 of 55 checks passed
@maanug-nv maanug-nv deleted the maanug/pax-rosetta-mgmn branch September 5, 2023 18:28
@maanug-nv
Copy link
Contributor Author

'resource not found' on the README should be fixed when a new run of rosetta pax is launched from main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants