Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

Show image index for infer_many #612

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

lukeyeager
Copy link
Member

This mostly helpful when debugging shallow copy errors because it's easy to see when the first 16 images are wrong and everything else is right, for example. Hopefully with #603 those issues will go away and never come back, but this seems like it could still be useful.

Here's a screenshot of this feature used in conjunction with #608 (adds numbering to the bottom table):

infer-many-loop-index

@gheinrich
Copy link
Contributor

Thanks, this looks good to me.

Question: I was wondering whether we should show the index of images from the list in the file instead/too? The indices will differ if there are images we failed to load. Also, shall we show the paths to those images (with an error message instead of a set of predictions)?

@lukeyeager
Copy link
Member Author

I was wondering whether we should show the index of images from the list in the file instead/too? The indices will differ if there are images we failed to load. Also, shall we show the paths to those images (with an error message instead of a set of predictions)?

That's a good idea. Sounds like that would require passing even more data around from the ModelJob to the InferenceJob and then back again - right?

@gheinrich
Copy link
Contributor

That's a good idea. Sounds like that would require passing even more data around from the ModelJob to the InferenceJob and then back again - right?

I don't think that would be the case because the inference job already passes the list of path IDs it was able to successfully load through the inputs['ids'] list, like so:
https://github.com/NVIDIA/DIGITS/blob/master/digits/model/images/classification/views.py#L419

lukeyeager added a commit that referenced this pull request Mar 7, 2016
@lukeyeager lukeyeager merged commit 4134178 into NVIDIA:master Mar 7, 2016
@lukeyeager lukeyeager deleted the infer-many-loop-index branch March 7, 2016 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants