Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend gtk3 error NVIDIA/DIGITS#187 NVIDIA/DIGITS#78 #239

Closed
wants to merge 1 commit into from
Closed

Fix backend gtk3 error NVIDIA/DIGITS#187 NVIDIA/DIGITS#78 #239

wants to merge 1 commit into from

Conversation

nszceta
Copy link

@nszceta nszceta commented Aug 27, 2015

No description provided.

@lukeyeager
Copy link
Member

@gheinrich, it looks like you first suggested this fix at #187 (comment). Can you explain where you got this from and why it works? I'd rather not add another library dependency if this can be solved in another way.

@gheinrich
Copy link
Contributor

My vague understanding is that matplotlib can operate with a number of rendering backends. There are 'interactive' backends which allow the user to interact with the backend (I suppose for zooming, panning, etc.). There are also non-interactive backends that e.g. only allow the rendering to be saved to files. By default matplotlib uses Gtk3, which is an interactive backend and needs a working display. Matplotlib has an API to switch the rendering backend. Doing matplotlib.use('Agg') selects a non-interactive backend, as suggested on BVLC/caffe#861.

We are using skimage which relies on matplotlib and I think the 'fix' is to make sure we switch the matplotlib backend before using skimage. In my understanding we already have a dependency on matplotlib through skimage so I think the change does not add a new dependency.

@lukeyeager
Copy link
Member

Thanks for the explanation! Should we make that an explicit requirement in requirements.txt or is this a caffe-specific thing?

@nszceta
Copy link
Author

nszceta commented Aug 27, 2015

It is a dependency of skimage. Nothing needed.

Adam Gradzki
On Aug 27, 2015 4:57 PM, "Luke Yeager" notifications@github.com wrote:

Thanks for the explanation! Should we make that an explicit requirement in
requirements.txt or is this a caffe-specific thing?


Reply to this email directly or view it on GitHub
#239 (comment).

@lukeyeager
Copy link
Member

Right, but we don't explicitly require either scikit-image or matplotlib in requirements.txt - those are coming from Caffe's list. All libraries used in DIGITS ought to be listed in the DIGITS requirements, even if they're also listed in the pycaffe requirements.

@nszceta, can you add this line to requirements.txt in this pull request please?

matplotlib>=1.3.1

Also, I'll need you to send us a signed CLA before I can accept your contribution. Sorry for the inconvenience.

Send a signed copy of the Contributor License Agreement (CLA) to digits@nvidia.com.

- https://github.com/NVIDIA/DIGITS/blob/master/CONTRIBUTING.md#pull-requests

@nszceta
Copy link
Author

nszceta commented Aug 28, 2015

I can not sign the CLA at this time. Please close the pull request.

Adam Gradzki
On Aug 27, 2015 5:19 PM, "Luke Yeager" notifications@github.com wrote:

Right, but we don't explicitly require either scikit-image or matplotlib
in requirements.txt
https://github.com/NVIDIA/DIGITS/blob/v2.1.0/requirements.txt - those
are coming from Caffe's list
https://github.com/NVIDIA/caffe/blob/v0.13.1/python/requirements.txt.
All libraries used in DIGITS ought to be listed in the DIGITS requirements,
even if they're also listed in the pycaffe requirements.

@nszceta https://github.com/nszceta, can you add this line to
requirements.txt in this pull request please?

matplotlib>=1.3.1

Also, I'll need you to send us a signed CLA before I can accept your
contribution. Sorry for the inconvenience.

Send a signed copy of the Contributor License Agreement (CLA) to
digits@nvidia.com.

https://github.com/NVIDIA/DIGITS/blob/master/CONTRIBUTING.md#pull-requests


Reply to this email directly or view it on GitHub
#239 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants