This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Use envvars for configuration instead of a file #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to improve the time it takes to start tools (and this should be reflected on Travis test time too): before: $ time ./tools/inference.py --help
real 0m0.821sAfter: $ time ./tools/inference.py --help
real 0m0.438s |
gheinrich
suggested changes
Sep 20, 2016
| @classmethod | ||
| def get_extensions(cls, show_all): | ||
| return extensions.view.get_extensions(show_all=show_all) | ||
| if 'DIGITS_ALL_EXTENSIONS' in os.environ: |
| # make the directory | ||
| os.mkdir(self._config_file_value) | ||
|
|
||
| if 'DIGITS_MODE_TEST' in os.environ: |
There was a problem hiding this comment.
maybe move this to a function like you are doing for other options like log_file?
There was a problem hiding this comment.
Do you really think that's more legible? I thought I'd just keep it simple when I can.
There was a problem hiding this comment.
No I think it's fine this way, forget that comment.
| if config_value('caffe_root')['flavor'] == 'NVIDIA': | ||
| if config_value('caffe_root')['version'] > parse_version('0.14.0-alpha'): | ||
| if config_value('caffe')['flavor'] == 'NVIDIA': | ||
| if parse_version(config_value('caffe')['version']) > parse_version('0.14.0-alpha'): |
|
|
||
|
|
||
| if 'CAFFE_ROOT' in os.environ: | ||
| executable, version, flavor = load_from_envvar('CAFFE_ROOT') |
| raise ValueError('Torch executable not found at "%s" (TORCH_HOME)' | ||
| % os.environ['TORCH_HOME']) | ||
| else: | ||
| executable = find_executable() |
I added a doc at |
gheinrich
reviewed
Sep 20, 2016
There was a problem hiding this comment.
Maybe edit the doc in https://github.com/NVIDIA/DIGITS/blob/v4.0.0/docs/BuildDigits.md#building-digits too?
gheinrich
approved these changes
Sep 20, 2016
|
Oops, I meant to squash before merging. Sorry. |
This was referenced Sep 26, 2016
Merged
Merged
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
Use envvars for configuration instead of a file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #941, close #180, fix #1090
Bug 1804528
Also,