Apply device context when converting to torch tensors #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edknv
force-pushed
the
multi_gpu_cupy_device
branch
from
147655a to
6f02abd
Compare
This was referenced Apr 17, 2023
karlhigley
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #132 but this PR applies the
torch.cuda.devicecontext only when converting numpy/cupy arrays to torch tensors. Unlike #132, it doesn't usecupy.cuda.Device, which did not work with tensorflow as discovered in Models multi-gpu tests.Note: In addition to the fix in this PR, users have to set
cupy.cuda.Device()manually. See here for details. Follow-up: Enable setting device in Core/Dataset. Add 2GPU unit tests in dataloader.