Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system_clock is NOT monotonic, and we should use steady_clock instead #2

Merged
merged 1 commit into from
Oct 21, 2019
+16 −16
Merged

system_clock is NOT monotonic, and we should use steady_clock instead #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions HugeCTR/include/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,36 +37,36 @@ namespace HugeCTR {
class Timer {
public:
void start() {
m_StartTime_ = std::chrono::system_clock::now();
m_StartTime_ = std::chrono::steady_clock::now();
m_bRunning_ = true;
}
void stop() {
m_EndTime_ = std::chrono::system_clock::now();
m_EndTime_ = std::chrono::steady_clock::now();
m_bRunning_ = false;
}
double elapsedMilliseconds() {
std::chrono::time_point<std::chrono::system_clock> endTime;
if (m_bRunning_) {
endTime = std::chrono::system_clock::now();
} else {
endTime = m_EndTime_;
}
return std::chrono::duration_cast<std::chrono::milliseconds>(endTime - m_StartTime_).count();
return std::chrono::duration_cast<std::chrono::milliseconds>(elapsed()).count();
}
double elapsedMicroseconds() {
std::chrono::time_point<std::chrono::system_clock> endTime;
return elapsed().count();
}
double elapsedSeconds() {
return std::chrono::duration_cast<std::chrono::seconds>(elapsed()).count();
}

private:
std::chrono::microseconds elapsed() {
std::chrono::time_point<std::chrono::steady_clock> endTime;
if (m_bRunning_) {
endTime = std::chrono::system_clock::now();
endTime = std::chrono::steady_clock::now();
} else {
endTime = m_EndTime_;
}
return std::chrono::duration_cast<std::chrono::microseconds>(endTime - m_StartTime_).count();
return std::chrono::duration_cast<std::chrono::microseconds>(endTime - m_StartTime_);
}
double elapsedSeconds() { return elapsedMilliseconds() / 1000.0; }

private:
std::chrono::time_point<std::chrono::system_clock> m_StartTime_;
std::chrono::time_point<std::chrono::system_clock> m_EndTime_;
std::chrono::time_point<std::chrono::steady_clock> m_StartTime_{};
std::chrono::time_point<std::chrono::steady_clock> m_EndTime_{};
bool m_bRunning_ = false;
};

Expand Down