Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Update CUB submodule to new URL and version 1.11.0 #569

Merged

Conversation

ahehn-nv
Copy link
Contributor

No description provided.

@ahehn-nv ahehn-nv added the sdk Overall SDK related improvements label Sep 23, 2020
@ahehn-nv ahehn-nv requested a review from tijyojwad September 23, 2020 08:41
@ahehn-nv ahehn-nv self-assigned this Sep 23, 2020
@mimaric
Copy link
Member

mimaric commented Sep 23, 2020

Should we still download CUB when using CUDA 11? I guess one cannot know CUDA version upfront, but in that case we probably should not have downloaded CUB in the include path

@ahehn-nv
Copy link
Contributor Author

Some logic in CMake to use the submodule only for CUDA <11.0 makes sense.
However, for CUDA 11 it shouldn't make much difference, since I updated the submodule to the version shipped with CUDA 11.

@mimaric
Copy link
Member

mimaric commented Sep 23, 2020

I agree. I would suggest linking this PR to issue #570, but not closing it until that is done in a separate PR

@ahehn-nv ahehn-nv linked an issue Sep 23, 2020 that may be closed by this pull request
@tijyojwad
Copy link
Contributor

@ahehn-nv - the CUDA 9.0 test seems to have failed. Can you have a look? perhaps we should make this change once we remove CUDA 9.0 support?

@ahehn-nv
Copy link
Contributor Author

Yes, let's postpone this. CUDA 9 compilation fails due to a bug in CUB - see NVIDIA/cub#207.
Since there's also a ticket for this task, I'll close this PR.

@ahehn-nv ahehn-nv closed this Sep 30, 2020
@mimaric mimaric self-requested a review November 24, 2020 17:32
@mimaric mimaric reopened this Nov 24, 2020
@mimaric
Copy link
Member

mimaric commented Nov 24, 2020

PR NVIDIA/cub#207 has been merged into CUB. The bug it solved was preventing us from using latest CUB version with CUDA 9.
Reopening this PR.
CUB 1.11.0 (RC available) bring big improvement to radix sort which in turn improves the performance of cudamapper.

@mimaric
Copy link
Member

mimaric commented Nov 25, 2020

The tests pass now. I suggest waiting for non-rc version of CUB 1.11.0 and merging then

@tijyojwad
Copy link
Contributor

@mimaric @ahehn-nv - CUDA 9 has been removed from our CI now.

@mimaric
Copy link
Member

mimaric commented Dec 7, 2020

@ahehn-nv CUB 1.11.0 has been released (https://github.com/NVIDIA/cub/releases/tag/1.11.0). Can you update this PR?

@ahehn-nv
Copy link
Contributor Author

ahehn-nv commented Dec 7, 2020

The PR is already up-to-date. CUB's 1.11.0-rc1 and 1.11.0 tags point to the same commit.

@ahehn-nv ahehn-nv merged commit 8553b59 into NVIDIA-Genomics-Research:dev-v0.6.0 Dec 7, 2020
@ahehn-nv ahehn-nv deleted the ahehn/update_cub branch December 7, 2020 10:44
@mimaric mimaric changed the title [sdk] Update CUB submodule to new URL and version 1.9.9 [sdk] Update CUB submodule to new URL and version 1.11.0 Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Overall SDK related improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Update the way we fetch CUB
3 participants