-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Update CUB submodule to new URL and version 1.11.0 #569
[sdk] Update CUB submodule to new URL and version 1.11.0 #569
Conversation
Should we still download CUB when using CUDA 11? I guess one cannot know CUDA version upfront, but in that case we probably should not have downloaded CUB in the include path |
Some logic in CMake to use the submodule only for CUDA <11.0 makes sense. |
I agree. I would suggest linking this PR to issue #570, but not closing it until that is done in a separate PR |
@ahehn-nv - the CUDA 9.0 test seems to have failed. Can you have a look? perhaps we should make this change once we remove CUDA 9.0 support? |
Yes, let's postpone this. CUDA 9 compilation fails due to a bug in CUB - see NVIDIA/cub#207. |
PR NVIDIA/cub#207 has been merged into CUB. The bug it solved was preventing us from using latest CUB version with CUDA 9. |
eb064ed
to
7ec0978
Compare
The tests pass now. I suggest waiting for non-rc version of CUB 1.11.0 and merging then |
@ahehn-nv CUB 1.11.0 has been released (https://github.com/NVIDIA/cub/releases/tag/1.11.0). Can you update this PR? |
The PR is already up-to-date. CUB's 1.11.0-rc1 and 1.11.0 tags point to the same commit. |
No description provided.