feat: remove need for studentId from excuse creation

NUS-SoC-TIPS · Jun 9, 2024 · e47f9db · e47f9db
1 parent e6230eb
commit e47f9db
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/src/product/general/excuses/dtos/create-excuse.dto.ts b/src/product/general/excuses/dtos/create-excuse.dto.ts
@@ -14,8 +14,4 @@ export class CreateExcuseDto {
   @IsNumber()
   @IsNotEmpty()
   windowId: number;
-
-  @IsNumber()
-  @IsNotEmpty()
-  studentId: number;
 }
diff --git a/src/product/general/excuses/excuses.controller.ts b/src/product/general/excuses/excuses.controller.ts
@@ -68,10 +68,13 @@ export class ExcusesController {
 
   @Post('/create')
   @UseFilters(BadRequestExceptionFilter)
-  createExcuse(@Body() dto: CreateExcuseDto): Promise<number> {
+  createExcuse(
+    @Body() dto: CreateExcuseDto,
+    @GetUserRest() user: User,
+  ): Promise<number> {
     this.logger.log('POST /excuses/create', ExcusesController.name);
 
-    return this.excusesService.createExcuse(dto);
+    return this.excusesService.createExcuse(dto, user);
   }
 
   @Put(':id')

diff --git a/src/product/general/excuses/excuses.service.ts b/src/product/general/excuses/excuses.service.ts
@@ -49,9 +49,18 @@ export class ExcusesService {
     return excuses.map((excuse) => makeExcuseBase(excuse));
   }
 
-  async createExcuse(excuse: CreateExcuseDto): Promise<number> {
+  async createExcuse(excuse: CreateExcuseDto, user: User): Promise<number> {
+    const student = await this.prismaService.student.findFirst({
+      where: { userId: user.id },
+    });
+
+    if (!student) {
+      throw new Error('Student not found');
+    }
+
     const createExcuseData = {
       ...excuse,
+      studentId: student.id,
       excuseStatus: ExcuseStatus.PENDING,
     };