Update Exterior Finish Options #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
approved these changes
Aug 24, 2021
joseph-robertson
added a commit
that referenced
this pull request
Jan 27, 2022
…f171e 568b25f171e Merge pull request #950 from NREL/time-cols 1369dda0a33 More cleanup items. 79112d731ca Tiny schema update from hpxmlwg/hpxml#302 ed4488f5577 Updates to epvalidator and tests after schema changes. b0c5497ff35 Move invalid timezone test. 6886d094b3f Fix tests. 8fcfe91d4be Updated schema. [ci skip] 9a3af6ea4e5 Add eGrid subregion too. 2035ae679dd Z character only in TimeUTC column. f1ea4cad2bb Move time zone validation into epvalidator. ab800467980 Fix args in output reporting measure. 0559f4d10b2 Oops, another bugfix. 8bba105b17b A couple bugfixes. (Also adds HPXML attributes for eGrid/Cambium regions.) bd165124311 Switch to new proposed TimeZone/UTCOffset HPXML element. 1a513ec064b Check for valid time zone in hpxml resource. f2e14aea504 Merge branch 'master' into time-cols 6989912e9c0 Update names in run_simulation. 4ce55b7a305 Few small changes to docs. 62f7982160a Update reporting measure arg names. 6d8876c66b5 Update translator resources and tests. 89ba65998e4 Update changelog. 3f3a11add1d Update build measure and tests. f881571b53b Merge pull request #967 from NREL/unitary_system_auto_fan ca8dd619b67 Clarifies blower fan schedule in code. Closes #682. 42c017280d1 Merge branch 'master' into time-cols c861f12cb88 Update changelog. 65c0741dfc5 Merge branch 'master' into time-cols d6a86ab643c Update hpxml and hpxml defaults resources. 900be80805a Update default header tests. 531e24b2402 Update epvalidator. 91adee824a1 Update docs. 2fcde9511a8 Update changelog. 2b3b34f293f Move valid time zone choices to constants resource. d1cc509f9e1 Merge branch 'move-build-defaults' into time-cols af0de92c906 Merge branch 'move-build-defaults' into time-cols 097c6dab0f6 Merge branch 'move-build-defaults' into time-cols e8fce184586 Merge branch 'move-build-defaults' into time-cols a71071c2007 Move iecc defaulting out of build measure. 9ffddcfa91c Move state and time zone defaulting out of build measure. 03eca8e6c10 Merge branch 'master' into time-cols 61209d391d8 More variable name changes. c4b43b3efd9 Update the docs. c3a763ec87a Change time zone element name and clean up. 1068c916289 Typo in hpxml resource. 151b07984b6 Merge branch 'master' into time-cols bddc1cf9699 Instead store time zone in hpxml and retrieve from reporting measure. dd15c24167d Add optional argument for utc offset. 42f5e28d6bd Ability to add dst and utc. 6c98510498c Fix timeseries csv formatting. f8e0a96211f Update run_simulation script with clock time arg. 33aee1dd4c9 Update template osw. 9f595e1cb9a Update and add reporting tests. 0054bb7e699 Add local time choice arg to reporting measure. 6f879c117d2 Use ISO 8601 format. git-subtree-dir: resources/hpxml-measures git-subtree-split: 568b25f171ee3f04d75566179fd2eb02319ccd35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: https://github.com/NREL/resstock-estimation/pull/168
Pull Request Description
Avoids invalid exterior finish options for OS-HPXML (project_testing and project_national), and updates for clarity. Changes include:
Noneoption for brick walls with brick exterior finishes (brick exterior finishes are now invalid for brick walls)Noneoption for CMU walls with concrete exterior finishesChecklist
Not all may apply:
project_testingproject_testingruns without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.