Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3 support #56

Closed
mdeceglie opened this issue Nov 28, 2017 · 7 comments
Closed

Add python 3 support #56

mdeceglie opened this issue Nov 28, 2017 · 7 comments
Labels
Fixed in development branch

Comments

@mdeceglie
Copy link
Collaborator

No description provided.

@jimjosephjohn
Copy link

Is python 3 support done?.

@mdeceglie
Copy link
Collaborator Author

Nope, this is still on the to do list. If you should take it on, once your changes are ready for review, please open a pull request to the development branch. Thanks for your interest and support!

@jimjosephjohn
Copy link

I am still getting used to the tool.

Great work.

@mdeceglie mdeceglie mentioned this issue Feb 22, 2018
Merged
@mikofski
Copy link
Contributor

I will help with this

mikofski added a commit to mikofski/rdtools that referenced this issue Feb 24, 2018
@mikofski
add note regarding Python-3 compatibility
22c6d9d 
The specific text is:

"_Note_: RdTools is compatible with Python-2. See [issue NREL#56](../..NREL/issues/56) to contribute to Python-3 support."
@mikofski mikofski mentioned this issue Feb 24, 2018
Merged
@mikofski
Copy link
Contributor

mikofski commented Feb 24, 2018 •
edited
Loading

@mdeceglie I think this is good to go. Can you think of any more tests to try? Maybe just it shake it around a bit to see what falls out first?

@mdeceglie
Copy link
Collaborator Author

@mikofski, awesome, thanks for your help on this issue! I'll take a look in the coming week.

@mdeceglie
Copy link
Collaborator Author

Fixed in development with PR #72

@mdeceglie mdeceglie mentioned this issue Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in development branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikofski @mdeceglie @jimjosephjohn