Skip to content

Commit

Permalink
Fixes #76
Browse files Browse the repository at this point in the history
  • Loading branch information
shorowit committed May 2, 2024
1 parent 473f9e7 commit b47ca7e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 62 deletions.
4 changes: 2 additions & 2 deletions lib/measures/UnmetLoadHoursTroubleshooting/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_unmet_hours_matrix(zoneMetrics)
@metrics[:toleranceTimeHeatSetUnmet] = d.getDouble(1).empty? ? 0.2 : d.getDouble(1).get
@metrics[:toleranceTimeCoolSetUnmet] = d.getDouble(2).empty? ? 0.2 : d.getDouble(2).get
end
# We must use Kelvin -> Rankine conversion instead of Celsius -> Farenheit because the latter conversion adds the 32 degree offset
# We must use Kelvin -> Rankine conversion instead of Celsius -> Fahrenheit because the latter conversion adds the 32 degree offset
@metrics[:toleranceTimeHeatSetUnmetF] = OpenStudio.convert(@metrics[:toleranceTimeHeatSetUnmet], 'K', 'R').get
@metrics[:toleranceTimeCoolSetUnmetF] = OpenStudio.convert(@metrics[:toleranceTimeCoolSetUnmet], 'K', 'R').get

Expand Down Expand Up @@ -258,7 +258,7 @@ def plant_loop_temp_vs_setpoints(zoneMetrics)

rawMin, rawMax = getMinMaxForSchedule(schedule)

exit_temp = plantloop.sizingPlant.getDesignLoopExitTemperature.value
exit_temp = plantloop.sizingPlant.designLoopExitTemperature
exit_temp = OpenStudio.convert(exit_temp, 'C', 'F').get

maxSetpointValue = OpenStudio.convert(rawMax, 'C', 'F').get
Expand Down
64 changes: 4 additions & 60 deletions lib/measures/UnmetLoadHoursTroubleshooting/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,64 +8,8 @@
<xml_checksum>5BFE84C4</xml_checksum>
<class_name>UnmetLoadHoursTroubleshooting</class_name>
<display_name>Unmet Load Hours Troubleshooting</display_name>
<description>Unmet load hours are any hours of operation when conditioned spaces are outside the throttling range for heating or cooling controls. That is, they are the hours in a year that the HVAC system serving a space cannot maintain space setpoint. This measure performs a series of checks against various model input variables and when applicable informs the user of possible sources of unmet cooling and heating hours. The measure also creates a dynamic time series plot of unmet cooling and heating hours, by zone - whose patterns may be interpreted to assist in troubleshooting unmet cooling and heating hours. Prior to running this measure, users will need to add the following output variables to their model: 1) Zone Mean Air Temperature,hourly 2) Zone Thermostat Heating Setpoint Temperature, hourly 3) Zone Thermostat Cooling Setpoint Temperature, hourly 4) Zone People Occupant Count, hourly using the AddOutputVariable OS measure, or the add output variables screen in the OpenStudio application.



























</description>
<modeler_description>This measure performs a series of logic checks against model inputs for diagnosing common issues responsible for unmet cooling and heating hours. The measure will also create a time series interactive chart (using dygraph libraries) to provide a visual inspection of when unmet heating and cooling hours are occurring.



























</modeler_description>
<description>Unmet load hours are any hours of operation when conditioned spaces are outside the throttling range for heating or cooling controls. That is, they are the hours in a year that the HVAC system serving a space cannot maintain space setpoint. This measure performs a series of checks against various model input variables and when applicable informs the user of possible sources of unmet cooling and heating hours. The measure also creates a dynamic time series plot of unmet cooling and heating hours, by zone - whose patterns may be interpreted to assist in troubleshooting unmet cooling and heating hours. Prior to running this measure, users will need to add the following output variables to their model: 1) Zone Mean Air Temperature,hourly 2) Zone Thermostat Heating Setpoint Temperature, hourly 3) Zone Thermostat Cooling Setpoint Temperature, hourly 4) Zone People Occupant Count, hourly using the AddOutputVariable OS measure, or the add output variables screen in the OpenStudio application.</description>
<modeler_description>This measure performs a series of logic checks against model inputs for diagnosing common issues responsible for unmet cooling and heating hours. The measure will also create a time series interactive chart (using dygraph libraries) to provide a visual inspection of when unmet heating and cooling hours are occurring.</modeler_description>
<arguments>
<argument>
<name>measure_zone</name>
Expand Down Expand Up @@ -157,8 +101,8 @@
<file>
<version>
<software_program>OpenStudio</software_program>
<identifier>2.0.0</identifier>
<min_compatible>2.0.0</min_compatible>
<identifier>3.0.0</identifier>
<min_compatible>3.0.0</min_compatible>
</version>
<filename>measure.rb</filename>
<filetype>rb</filetype>
Expand Down

0 comments on commit b47ca7e

Please sign in to comment.