Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclosure windows and skylights #19

Merged
merged 15 commits into from
Apr 27, 2021
Merged

Enclosure windows and skylights #19

merged 15 commits into from
Apr 27, 2021

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Apr 20, 2021

address #6
closes #9

@bpark1327 bpark1327 self-assigned this Apr 20, 2021
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably didn't catch them all, but see my comment below about making sure we copy the appropriate information over before deleting elements.

hpxml_version_translator/converter.py Outdated Show resolved Hide resolved
@bpark1327 bpark1327 changed the title Enclosure windows Enclosure windows and skylights Apr 26, 2021
@bpark1327 bpark1327 requested a review from nmerket April 26, 2021 21:59
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments below.

hpxml_version_translator/converter.py Outdated Show resolved Hide resolved
hpxml_version_translator/converter.py Outdated Show resolved Hide resolved
hpxml_version_translator/converter.py Outdated Show resolved Hide resolved
hpxml_version_translator/converter.py Outdated Show resolved Hide resolved
hpxml_version_translator/converter.py Outdated Show resolved Hide resolved
hpxml_version_translator/converter.py Outdated Show resolved Hide resolved
bpark1327 and others added 2 commits April 27, 2021 12:08
@bpark1327 bpark1327 merged commit faaf0b6 into main Apr 27, 2021
@bpark1327 bpark1327 deleted the enclosure_windows branch April 27, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window/Skylight Interior Shading Fraction
2 participants