Enclosure attics and roofs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmerket
requested changes
Apr 20, 2021
Co-authored-by: Noel Merket <noel.merket@nrel.gov>
…ion_translator into enclosure_attics
shorowit
reviewed
Apr 22, 2021
…RoofInsulation, Attic/Area, Attic/Rafters
… into enclosure_attics
nmerket
reviewed
Apr 23, 2021
nmerket
reviewed
Apr 23, 2021
There was a problem hiding this comment.
This looks good. This part of the translation is probably the most complicated in this whole project. I was just looking at the coverage report and it might be good to do some more tests to cover more of the branches in the code
For example:
Here's some instructions for looking at the coverage report.
nmerket
approved these changes
Apr 26, 2021
… into enclosure_attics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #6