Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background logging fix #33

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Background logging fix #33

merged 4 commits into from
Nov 6, 2023

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Nov 6, 2023

No more terminal spam when submitting recursive pipeline with --background option

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (080f0fc) 98.06% compared to head (a17eda2) 98.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   98.06%   98.07%           
=======================================
  Files          28       28           
  Lines        2897     2902    +5     
  Branches      485      485           
=======================================
+ Hits         2841     2846    +5     
  Misses         35       35           
  Partials       21       21           
Flag Coverage Δ
unittests 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gaps/cli/config.py 100.00% <100.00%> (ø)
gaps/cli/pipeline.py 98.73% <100.00%> (ø)
gaps/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 9b1b6cc into main Nov 6, 2023
12 checks passed
@ppinchuk ppinchuk deleted the pp/bg_log_fix branch November 6, 2023 23:46
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants