Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch + monitor + background fix #20

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Batch + monitor + background fix #20

merged 6 commits into from
Sep 7, 2023

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Sep 7, 2023

Implements a fix for some combinations of batch + monitor + background. Found out minor issues with these while testing sup3r

@ppinchuk ppinchuk added the bugfix Fixed a known bug label Sep 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (a135c89) 98.10% compared to head (e1b2915) 98.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          26       26           
  Lines        2686     2694    +8     
  Branches      450      451    +1     
=======================================
+ Hits         2635     2643    +8     
  Misses         35       35           
  Partials       16       16           
Flag Coverage Δ
unittests 98.10% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gaps/batch.py 98.31% <81.81%> (+0.03%) ⬆️
gaps/cli/pipeline.py 98.27% <100.00%> (ø)
gaps/pipeline.py 98.86% <100.00%> (+0.01%) ⬆️
gaps/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit c040ad8 into main Sep 7, 2023
@ppinchuk ppinchuk deleted the pp/batch_background_fix branch September 7, 2023 19:39
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants