Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added protection against bad batch inputs with test #19

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

grantbuster
Copy link
Member

No description provided.

@grantbuster grantbuster requested a review from ppinchuk September 1, 2023 20:32
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that. Anything we can do to make batch more user-friendly is a win TBH.

The linter is going to complain a bit but feel free to ignore it and merge anyways. NVM, we're good!

@grantbuster
Copy link
Member Author

Thanks for doing that. Anything we can do to make batch more user-friendly is a win TBH.

The linter is going to complain a bit but feel free to ignore it and merge anyways. NVM, we're good!

Psh yeah my code style is CLEAN!

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.15% ⚠️

Comparison is base (6e9092d) 98.24% compared to head (3e74d86) 98.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   98.24%   98.10%   -0.15%     
==========================================
  Files          26       26              
  Lines        2674     2685      +11     
  Branches      447      450       +3     
==========================================
+ Hits         2627     2634       +7     
- Misses         32       35       +3     
- Partials       15       16       +1     
Flag Coverage Δ
unittests 98.10% <69.23%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gaps/cli/documentation.py 100.00% <ø> (ø)
gaps/batch.py 98.28% <69.23%> (-1.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grantbuster grantbuster merged commit 38b46fe into main Sep 1, 2023
@grantbuster grantbuster deleted the gb/batch_edits branch September 1, 2023 20:53
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
added protection against bad batch inputs with test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants