-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModelFit #206
Closed
Closed
ModelFit #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@misi9170, this is now starting to have a little more pieces fleshed out so wanted to have you take a quick look at this point and maybe we can discuss a little bit on Monday. Note there is definitely a bug in example 1 I haven't found yet but wanted more your comment on structure and names of things |
Closed
This PR now replaced by #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelFit
Feature or improvement description
ModelFit is a new modular framework for fitting FLORIS models to SCADA data. This draft pull request is being opened early in development enable collaboration. This documentation will also be expanded as development progresses.
Running log of notes:
Todo
Related issue, if one exists
Note this is currently not branching from develop but from #199 in order to include the
FlascDataframe
class.Impacted areas of the software