Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelFit #206

Closed
wants to merge 41 commits into from
Closed

ModelFit #206

wants to merge 41 commits into from

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Aug 20, 2024

ModelFit

Feature or improvement description
ModelFit is a new modular framework for fitting FLORIS models to SCADA data. This draft pull request is being opened early in development enable collaboration. This documentation will also be expanded as development progresses.

Running log of notes:

  • ModelFit can be run without optimization, just evaluating fitness, but not passing in parameters or optimization and just calling the fitness evaluation functions

Todo

  • For CI, currently develop branch of FLORIS installed to capture certain improvements to ParallelFlorisModel, revert before finished

Related issue, if one exists

Note this is currently not branching from develop but from #199 in order to include the FlascDataframe class.

Impacted areas of the software

@paulf81 paulf81 added the enhancement An improvement of an existing feature label Aug 20, 2024
@paulf81
Copy link
Collaborator Author

paulf81 commented Aug 23, 2024

@misi9170, this is now starting to have a little more pieces fleshed out so wanted to have you take a quick look at this point and maybe we can discuss a little bit on Monday. Note there is definitely a bug in example 1 I haven't found yet but wanted more your comment on structure and names of things

@paulf81 paulf81 mentioned this pull request Sep 17, 2024
@paulf81
Copy link
Collaborator Author

paulf81 commented Sep 17, 2024

This PR now replaced by #213

@paulf81 paulf81 closed this Sep 17, 2024
@paulf81 paulf81 deleted the feature/modelfit branch September 17, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants