Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using serde_derive crate directly rather than serde derive feature #49

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ codegen-units = 1 # optimize connection between modules
anyhow = "1.0.57"
pyo3 = "0.19"
pyo3-log = "*"
serde = "1.0.143"
serde = "1.0.186"
serde_json = "1.0.83"
serde_yaml = "0.9.22"
serde_derive = "1.0.186"

1 change: 1 addition & 0 deletions rust/fastsim-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ repository = "https://github.com/NREL/fastsim"
fastsim-core = { path = "../fastsim-core", version = "~0" }
serde = { workspace = true }
serde_json = { workspace = true }
serde_derive = { workspace = true }
project-root = "0.2.2"
clap = { version = "3.2.6", features = ["derive"] }
regex = "1"
Expand Down
2 changes: 1 addition & 1 deletion rust/fastsim-cli/src/bin/fastsim-cli.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use clap::{ArgGroup, Parser};
use serde::{Deserialize, Serialize};
use serde_derive::{Deserialize, Serialize};
use serde_json::{json, Value};

use std::fs;
Expand Down
3 changes: 2 additions & 1 deletion rust/fastsim-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ pyo3 = { workspace = true, features = [
"anyhow",
], optional = true }
anyhow = { workspace = true }
serde = { workspace = true, features = ["derive"] }
serde = { workspace = true }
serde_derive = { workspace = true }
serde_yaml = { workspace = true }
ndarray = { version = "0.15.4", features = ["serde"] }
csv = "1.1"
Expand Down
3 changes: 1 addition & 2 deletions rust/fastsim-core/src/imports.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@ pub(crate) use anyhow::{anyhow, bail, ensure};
pub(crate) use bincode::{deserialize, serialize};
pub(crate) use log;
pub(crate) use ndarray::{array, concatenate, s, Array, Array1, Axis};
pub(crate) use serde::{Deserialize, Serialize};
pub(crate) use serde_derive::{Deserialize, Serialize};
pub(crate) use std::cmp;
pub(crate) use std::ffi::OsStr;
pub(crate) use std::fs::File;
pub(crate) use std::path::{Path, PathBuf};

pub(crate) use crate::traits::*;
pub(crate) use crate::utils::*;

2 changes: 1 addition & 1 deletion rust/fastsim-core/src/simdrivelabel.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Module containing classes and methods for calculating label fuel economy.

use ndarray::Array;
use serde::Serialize;
use serde_derive::Serialize;
use std::collections::HashMap;

// crate local
Expand Down
4 changes: 2 additions & 2 deletions rust/fastsim-core/src/traits.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::imports::*;
use std::collections::HashMap;

pub trait SerdeAPI: Serialize + for<'a> Deserialize<'a> {
pub trait SerdeAPI: serde::Serialize + for<'a> serde::Deserialize<'a> {
/// runs any initialization steps that might be needed
fn init(&mut self) -> anyhow::Result<()> {
Ok(())
Expand Down Expand Up @@ -45,7 +45,7 @@ pub trait SerdeAPI: Serialize + for<'a> Deserialize<'a> {
fn from_file(filename: &str) -> Result<Self, anyhow::Error>
where
Self: std::marker::Sized,
for<'de> Self: Deserialize<'de>,
for<'de> Self: serde::Deserialize<'de>,
{
let extension = Path::new(filename)
.extension()
Expand Down