Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copied better SerdeAPI from altrios #26

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

calbaker
Copy link
Collaborator

No description provided.

@calbaker calbaker requested a review from kylecarow June 13, 2023 15:39
Copy link
Collaborator

@kylecarow kylecarow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


fn to_file(&self, filename: &str) -> anyhow::Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Didn't know anyhow had its own Result built in. That's convenient.

@kylecarow kylecarow merged commit e0eb6a4 into fastsim-2 Jun 13, 2023
@kylecarow kylecarow deleted the serde-api-improvements branch June 13, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants